Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update dangerJS #63854

Closed
wants to merge 3 commits into from
Closed

Conversation

snitin315
Copy link

@snitin315 snitin315 commented Jan 9, 2023

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 9, 2023

@snitin315 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63854,
  "author": "snitin315",
  "headCommitOid": "6380089847c34e08287d04b8c4406301aa62c419",
  "mergeBaseOid": "f7924494bbccf8d8c4a0874d06af2bf0ade24aa4",
  "lastPushDate": "2023-01-09T10:17:26.000Z",
  "lastActivityDate": "2023-01-09T20:48:56.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": ".github/workflows/CI.yml",
          "kind": "infrastructure"
        },
        {
          "path": "dangerfile.ts",
          "kind": "infrastructure"
        },
        {
          "path": "package.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1375375852,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @snitin315 — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jan 9, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Jan 9, 2023
@DangerBotOSS
Copy link

Fails
🚫 Test warning

Generated by 🚫 dangerJS against 6380089

@snitin315 snitin315 closed this Jan 9, 2023
@snitin315 snitin315 reopened this Jan 9, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jan 9, 2023
@DangerBotOSS
Copy link

Fails
🚫 Test warning

Generated by 🚫 dangerJS against 6380089

1 similar comment
@DangerBotOSS
Copy link

Fails
🚫 Test warning

Generated by 🚫 dangerJS against 6380089

@peterblazejewicz
Copy link
Member

@snitin315 can we close it now, as it appear to work? (bot prints msg)

@snitin315
Copy link
Author

Yes we can close it.

@snitin315 snitin315 closed this Jan 10, 2023
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Jan 10, 2023
@snitin315 snitin315 deleted the patch-1 branch January 13, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants