Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightwatchjs] Add types for Appium commands. #63832

Merged
merged 1 commit into from Jan 9, 2023

Conversation

garg3133
Copy link
Contributor

@garg3133 garg3133 commented Jan 6, 2023

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: PR1, PR2
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 6, 2023

@garg3133 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63832,
  "author": "garg3133",
  "headCommitOid": "dca8ea9bb6cf51f6d500480dcb5bbf57a9e11c12",
  "mergeBaseOid": "512a2c28ee32918c20aaa37283b0b8984ab2d511",
  "lastPushDate": "2023-01-06T17:47:36.000Z",
  "lastActivityDate": "2023-01-09T14:35:48.000Z",
  "mergeOfferDate": "2023-01-09T14:35:15.000Z",
  "mergeRequestDate": "2023-01-09T14:35:48.000Z",
  "mergeRequestUser": "garg3133",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "nightwatch",
      "kind": "edit",
      "files": [
        {
          "path": "types/nightwatch/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nightwatch/test/nightwatch-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/nightwatch/test/testAppiumCommands.ts",
          "kind": "test"
        },
        {
          "path": "types/nightwatch/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "rkavalap",
        "schlesiger",
        "ClaytonAstrom",
        "lloiser",
        "vaibhavsingh97",
        "beatfactor",
        "AutomatedTester",
        "gravityvi",
        "swrdfish",
        "harshit-bs",
        "literallyMello",
        "lukebickell",
        "garg3133"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "swrdfish",
      "date": "2023-01-09T14:34:29.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1373954239,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Jan 6, 2023
@typescript-bot
Copy link
Contributor

🔔 @rkavalap @schlesiger @ClaytonAstrom @lloiser @vaibhavsingh97 @beatfactor @AutomatedTester @gravityvi @swrdfish @harshit-bs @literallyMello @lukebickell — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 6, 2023
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

nightwatch (unpkg)

was missing the following properties:

  1. createClient
  2. client
  3. cli
  4. runTests
  5. CliRunner
as well as these 2 other properties...

initClient, runner

Generated by 🚫 dangerJS against dca8ea9

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 9, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Jan 9, 2023
@typescript-bot
Copy link
Contributor

@garg3133: Everything looks good here. I am ready to merge this PR (at dca8ea9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@rkavalap, @schlesiger, @ClaytonAstrom, @lloiser, @vaibhavsingh97, @beatfactor, @AutomatedTester, @gravityvi, @swrdfish, @harshit-bs, @literallyMello, @lukebickell: you can do this too.)

@garg3133
Copy link
Contributor Author

garg3133 commented Jan 9, 2023

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jan 9, 2023
@typescript-bot typescript-bot merged commit 8405a45 into DefinitelyTyped:master Jan 9, 2023
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants