New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wordpress__components & wordpress__compose type mismatch after change to React v18 #63716
Conversation
@danieliser Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63716,
"author": "danieliser",
"headCommitOid": "e22ca61a9561b2cdf1920913b1a7675e888b345f",
"mergeBaseOid": "04d5ce209125122ab55ad7502c88a5ef05c1b9a8",
"lastPushDate": "2022-12-24T07:55:09.000Z",
"lastActivityDate": "2022-12-28T07:06:09.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wordpress__components",
"kind": "edit",
"files": [
{
"path": "types/wordpress__components/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__components/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford",
"sirreal",
"p-jackson",
"sarayourfriend",
"michaelhthomas",
"manzoorwanijk",
"bastolen"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__compose",
"kind": "edit",
"files": [
{
"path": "types/wordpress__compose/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__compose/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sirreal",
"date": "2022-12-28T07:06:09.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "noahtallen",
"date": "2022-12-27T20:05:54.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1364444605,
"ciResult": "pass"
} |
🔔 @dsifford @sirreal @p-jackson @sarayourfriend @michaelhthomas @manzoorwanijk @bastolen — please review this PR in the next few days. Be sure to explicitly select |
@typescript-bot Test changes were not necessary as the type mismatch came from a dependency version mismatch. |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. wordpress__components (unpkg)was missing the following properties:
as well as these 6 other properties...Line, SearchControl, TextHighlight, ToolbarDropdownMenu, ToolbarItem, useBaseControlProps wordpress__compose (unpkg)was missing the following properties:
as well as these 15 other properties...useDebounce, useDisabled, useFocusOnMount, useFocusReturn, useFocusableIframe, useInstanceId, useIsomorphicLayoutEffect, useKeyboardShortcut, useMergeRefs, usePrevious, useRefEffect, useResizeObserver, useThrottle, useViewportMatch, useWarnOnChange |
Didn't realize this PR included the update for @types/wordpress__compose as well, so bumped the version for it as well. Same issue fixed in both packages still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but I don't know if it will accept my approval!
@noahtallen - thanks, seems to have resolved everything we were seeing with react/JSX component type mismatches and loading of multiple @type/wordpress__ version library conflicts. |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: