Remove 3 Ember packages which publish their own types #63669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `@ember/test-helpers` - `ember-qunit` - `ember-resolver`
|
@chriskrycho Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 3 packages in this PR (and infra files)
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63669,
"author": "chriskrycho",
"headCommitOid": "62a3aa4f3656bb8882c7e332ad2f2724d6c2eef1",
"mergeBaseOid": "72a92411cee011774fa2f65ba0e2cf666614c8f4",
"lastPushDate": "2022-12-19T18:18:50.000Z",
"lastActivityDate": "2022-12-19T20:45:39.000Z",
"mergeOfferDate": "2022-12-19T20:35:16.000Z",
"mergeRequestDate": "2022-12-19T20:45:39.000Z",
"mergeRequestUser": "chriskrycho",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "ember-qunit",
"kind": "delete",
"files": [
{
"path": "types/ember-qunit/ember-qunit-tests.ts",
"kind": "test"
},
{
"path": "types/ember-qunit/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember-qunit/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-qunit/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-qunit/v2/ember-qunit-tests.ts",
"kind": "test"
},
{
"path": "types/ember-qunit/v2/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember-qunit/v2/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-qunit/v2/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-qunit/v4/ember-qunit-tests.ts",
"kind": "test"
},
{
"path": "types/ember-qunit/v4/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember-qunit/v4/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-qunit/v4/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dfreeman",
"chriskrycho",
"jamescdavis"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "ember-resolver",
"kind": "delete",
"files": [
{
"path": "types/ember-resolver/ember-resolver-tests.ts",
"kind": "test"
},
{
"path": "types/ember-resolver/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember-resolver/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-resolver/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-resolver/v4/ember-resolver-tests.ts",
"kind": "test"
},
{
"path": "types/ember-resolver/v4/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember-resolver/v4/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember-resolver/v4/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dfreeman",
"chriskrycho",
"jamescdavis",
"wagenet"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ember__test-helpers",
"kind": "delete",
"files": [
{
"path": "types/ember__test-helpers/application.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/blur.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/click.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/double-click.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/fill-in.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/find-all.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/find.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/focus.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/get-root-element.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/scroll-to.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/select.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/tap.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/trigger-event.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/trigger-key-event.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/triggerTab.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/type-in.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/dom/wait-for.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/ember__test-helpers-tests.ts",
"kind": "test"
},
{
"path": "types/ember__test-helpers/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/rerender.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/resolver.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/settled.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/setup-application-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/setup-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/setup-onerror.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/setup-rendering-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/teardown-application-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/teardown-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/teardown-rendering-context.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember__test-helpers/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember__test-helpers/v1/ember__test-helpers-tests.ts",
"kind": "test"
},
{
"path": "types/ember__test-helpers/v1/index.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/v1/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember__test-helpers/v1/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ember__test-helpers/validate-error-handler.d.ts",
"kind": "definition"
},
{
"path": "types/ember__test-helpers/wait-until.d.ts",
"kind": "definition"
}
],
"owners": [
"dfreeman",
"jamescdavis",
"wagenet",
"chriskrycho"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-12-19T20:34:28.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "wagenet",
"date": "2022-12-19T19:59:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1358063052,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
🔔 @dfreeman @jamescdavis @wagenet — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in New Pull Request Status Board
wagenet
approved these changes
Dec 19, 2022
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@chriskrycho: Everything looks good here. I am ready to merge this PR (at 62a3aa4) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
typescript-bot
moved this from Needs Maintainer Action
to Waiting for Author to Merge
in New Pull Request Status Board
|
Ready to merge |
typescript-bot
moved this from Waiting for Author to Merge
to Recently Merged
in New Pull Request Status Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ember/test-helpersember-qunitember-resolverits-happening.gif
Accompanying PR to add these to
allowedPackageJsonDependencies.Please fill in this template.
npm test <package to test>.If removing a declaration:
notNeededPackages.json.