-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-image-snapshot] add onlyDiff
option added in version 6.1.0
#63501
Conversation
Add changes introduced in americanexpress/jest-image-snapshot#317 to the types
@Ayc0 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63501,
"author": "Ayc0",
"headCommitOid": "93924fd9c5b34d8744aad9c22d55c8d4662df259",
"mergeBaseOid": "ef99180a81bea833ccb9e80631636fa4a959f17c",
"lastPushDate": "2022-12-06T08:47:13.000Z",
"lastActivityDate": "2022-12-06T19:04:52.000Z",
"mergeOfferDate": "2022-12-06T18:48:14.000Z",
"mergeRequestDate": "2022-12-06T19:04:38.000Z",
"mergeRequestUser": "Ayc0",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "jest-image-snapshot",
"kind": "edit",
"files": [
{
"path": "types/jest-image-snapshot/index.d.ts",
"kind": "definition"
},
{
"path": "types/jest-image-snapshot/jest-image-snapshot-tests.ts",
"kind": "test"
}
],
"owners": [
"dawnmist",
"erbridge",
"peterblazejewicz"
],
"addedOwners": [
"Ayc0"
],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-12-06T18:47:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1338967105,
"ciResult": "pass"
} |
🔔 @dawnmist @erbridge @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Ayc0 thanks!
@Ayc0: Everything looks good here. I am ready to merge this PR (at 93924fd) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dawnmist, @erbridge, @peterblazejewicz: you can do this too.) |
Ready to merge |
Thanks! |
Add changes introduced in americanexpress/jest-image-snapshot#317 to the types
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test jest-image-snapshot
.Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/americanexpress/jest-image-snapshot#%EF%B8%8F-api
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.