Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-image-snapshot] add onlyDiff option added in version 6.1.0 #63501

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

Ayc0
Copy link
Contributor

@Ayc0 Ayc0 commented Dec 6, 2022

Add changes introduced in americanexpress/jest-image-snapshot#317 to the types

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 6, 2022

@Ayc0 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63501,
  "author": "Ayc0",
  "headCommitOid": "93924fd9c5b34d8744aad9c22d55c8d4662df259",
  "mergeBaseOid": "ef99180a81bea833ccb9e80631636fa4a959f17c",
  "lastPushDate": "2022-12-06T08:47:13.000Z",
  "lastActivityDate": "2022-12-06T19:04:52.000Z",
  "mergeOfferDate": "2022-12-06T18:48:14.000Z",
  "mergeRequestDate": "2022-12-06T19:04:38.000Z",
  "mergeRequestUser": "Ayc0",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "jest-image-snapshot",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-image-snapshot/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest-image-snapshot/jest-image-snapshot-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dawnmist",
        "erbridge",
        "peterblazejewicz"
      ],
      "addedOwners": [
        "Ayc0"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-12-06T18:47:31.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1338967105,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Dec 6, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 6, 2022
@typescript-bot
Copy link
Contributor

🔔 @dawnmist @erbridge @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Dec 6, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Dec 6, 2022
@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Dec 6, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Dec 6, 2022
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@Ayc0 thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 6, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Dec 6, 2022
@typescript-bot
Copy link
Contributor

@Ayc0: Everything looks good here. I am ready to merge this PR (at 93924fd) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dawnmist, @erbridge, @peterblazejewicz: you can do this too.)

@Ayc0
Copy link
Contributor Author

Ayc0 commented Dec 6, 2022

Ready to merge

@Ayc0
Copy link
Contributor Author

Ayc0 commented Dec 6, 2022

Thanks!

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Dec 6, 2022
@typescript-bot typescript-bot merged commit 1ac821e into DefinitelyTyped:master Dec 6, 2022
@Ayc0 Ayc0 deleted the patch-1 branch December 6, 2022 19:21
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Owners This PR adds or removes owners Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants