New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prompts: Add missing onRender method to PromptObject #63453
prompts: Add missing onRender method to PromptObject #63453
Conversation
The new dependency on `kleur` has been merged; see microsoft/DefinitelyTyped-tools#573. This method is mentioned in the `README`: https://github.com/terkelg/prompts/blob/a0c1777ae86d04e46cb42eb3af69ca74ae5d79e2/readme.md#-prompt-objects
@boneskull Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
@boneskull: I see that you have added yourself as an owner, are you sure you want to become an owner? Code ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63453,
"author": "boneskull",
"headCommitOid": "9bf2c0fdc961d797f3b79e58f59d7fbc616f8ddd",
"mergeBaseOid": "86cb20c7f234f847a17d7d9fe8314604b49c01ba",
"lastPushDate": "2022-12-01T22:27:44.000Z",
"lastActivityDate": "2022-12-05T19:58:30.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2022-12-05T05:50:43.000Z",
"mergeRequestDate": "2022-12-05T19:58:30.000Z",
"mergeRequestUser": "boneskull",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "prompts",
"kind": "edit",
"files": [
{
"path": "types/prompts/index.d.ts",
"kind": "definition"
},
{
"path": "types/prompts/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Berkays",
"unindented",
"kamontat",
"theweirdone",
"whoaa512",
"johnnyreilly"
],
"addedOwners": [
"boneskull"
],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Whoaa512",
"date": "2022-12-02T01:38:30.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1334531138,
"ciResult": "pass"
} |
Hey @boneskull, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @Berkays @unindented @kamontat @theweirdone @Whoaa512 @johnnyreilly — please review this PR in the next few days. Be sure to explicitly select |
@boneskull: Everything looks good here. I am ready to merge this PR (at 9bf2c0f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Berkays, @unindented, @kamontat, @theweirdone, @Whoaa512, @johnnyreilly: you can do this too.) |
Ready to merge |
The new dependency on
kleur
has been merged; see microsoft/DefinitelyTyped-tools#573.This method is mentioned in the
README
: https://github.com/terkelg/prompts/blob/a0c1777ae86d04e46cb42eb3af69ca74ae5d79e2/readme.md#-prompt-objectsI cannot run any tests locally (via
npm test prompts
), asdtslint
fails, reporting invalid rules:I don't know what's wrong with my working copy or environment to cause this. If I can get it working, I will add a test for the new method.
Please fill in this template.
npm test <package to test>
.If changing an existing definition: