Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompts: Add missing onRender method to PromptObject #63453

Merged
merged 1 commit into from Dec 5, 2022

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Dec 1, 2022

The new dependency on kleur has been merged; see microsoft/DefinitelyTyped-tools#573.

This method is mentioned in the README: https://github.com/terkelg/prompts/blob/a0c1777ae86d04e46cb42eb3af69ca74ae5d79e2/readme.md#-prompt-objects

I cannot run any tests locally (via npm test prompts), as dtslint fails, reporting invalid rules:

/Users/boneskull/projects/DefinitelyTyped/DefinitelyTyped/types/prompts/index.d.ts
  1:1  error  Definition for rule 'export-just-namespace' was not found  export-just-namespace
  1:1  error  Definition for rule 'no-bad-reference' was not found       no-bad-reference
  1:1  error  Definition for rule 'trim-file' was not found              trim-file

/Users/boneskull/projects/DefinitelyTyped/DefinitelyTyped/types/prompts/prompts-tests.ts
  1:1  error  Definition for rule 'export-just-namespace' was not found  export-just-namespace
  1:1  error  Definition for rule 'no-bad-reference' was not found       no-bad-reference
  1:1  error  Definition for rule 'trim-file' was not found              trim-file

I don't know what's wrong with my working copy or environment to cause this. If I can get it working, I will add a test for the new method.


Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 1, 2022

@boneskull Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@boneskull: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63453,
  "author": "boneskull",
  "headCommitOid": "9bf2c0fdc961d797f3b79e58f59d7fbc616f8ddd",
  "mergeBaseOid": "86cb20c7f234f847a17d7d9fe8314604b49c01ba",
  "lastPushDate": "2022-12-01T22:27:44.000Z",
  "lastActivityDate": "2022-12-05T19:58:30.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2022-12-05T05:50:43.000Z",
  "mergeRequestDate": "2022-12-05T19:58:30.000Z",
  "mergeRequestUser": "boneskull",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "prompts",
      "kind": "edit",
      "files": [
        {
          "path": "types/prompts/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prompts/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Berkays",
        "unindented",
        "kamontat",
        "theweirdone",
        "whoaa512",
        "johnnyreilly"
      ],
      "addedOwners": [
        "boneskull"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Whoaa512",
      "date": "2022-12-02T01:38:30.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1334531138,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Dec 1, 2022
@typescript-bot
Copy link
Contributor

Hey @boneskull,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 1, 2022
@typescript-bot
Copy link
Contributor

🔔 @Berkays @unindented @kamontat @theweirdone @Whoaa512 @johnnyreilly — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Dec 1, 2022
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Dec 2, 2022
@RyanCavanaugh RyanCavanaugh moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Dec 5, 2022
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Dec 5, 2022
@typescript-bot
Copy link
Contributor

@boneskull: Everything looks good here. I am ready to merge this PR (at 9bf2c0f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Berkays, @unindented, @kamontat, @theweirdone, @Whoaa512, @johnnyreilly: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Dec 5, 2022
@boneskull
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Dec 5, 2022
@typescript-bot typescript-bot merged commit 6fa9349 into DefinitelyTyped:master Dec 5, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants