New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing WebGLRenderingContext type #63216
fixing WebGLRenderingContext type #63216
Conversation
@michaeljherrmann Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63216,
"author": "michaeljherrmann",
"headCommitOid": "e3033be6dd2fc41b1dda88cf6c5c376695bd4c35",
"mergeBaseOid": "5c0e878c1d24988ebc99cd65356c6addb996003f",
"lastPushDate": "2022-11-11T21:12:29.000Z",
"lastActivityDate": "2022-11-11T22:11:50.000Z",
"mergeOfferDate": "2022-11-11T21:58:00.000Z",
"mergeRequestDate": "2022-11-11T22:11:50.000Z",
"mergeRequestUser": "michaeljherrmann",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "gl",
"kind": "edit",
"files": [
{
"path": "types/gl/gl-tests.ts",
"kind": "test"
},
{
"path": "types/gl/index.d.ts",
"kind": "definition"
}
],
"owners": [
"DefinitelyTyped"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "stepancar",
"date": "2022-11-11T21:57:18.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1312158147,
"ciResult": "pass"
} |
🔔 @DefinitelyTyped — please review this PR in the next few days. Be sure to explicitly select |
@michaeljherrmann The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@michaeljherrmann The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@stepancar Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@michaeljherrmann: Everything looks good here. I am ready to merge this PR (at e3033be) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@DefinitelyTyped: you can do this too.) |
Ready to merge |
Follow up to fix the types introduced in #62647
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: