New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Synchronize ts4.8 with current #62416
node: Synchronize ts4.8 with current #62416
Conversation
The ts4.8 variant of `@types/node` was missing recent changes, in particular to `node:test`, which are backported via this patch.
@meyfa Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 62416,
"author": "meyfa",
"headCommitOid": "4917503731f409328e900756cbb4aa425822ed0a",
"mergeBaseOid": "0c0777bd1dd9b34f4fa4e36aecfdc3228e64d454",
"lastPushDate": "2022-09-26T08:36:19.000Z",
"lastActivityDate": "2022-10-04T15:02:02.000Z",
"mergeOfferDate": "2022-10-04T14:34:35.000Z",
"mergeRequestDate": "2022-10-04T15:02:02.000Z",
"mergeRequestUser": "meyfa",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/ts4.8/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/test/test.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2022-10-04T14:33:51.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "LinusU",
"date": "2022-10-04T10:07:27.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1257696667,
"ciResult": "pass"
} |
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select |
I think this should be updated with the changes from #59905, but I may need a few days until I get to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM 👍
Ready to merge |
We may need to create a followup PR for that, but at least we got these changes in. Thanks everyone! |
The ts4.8 variant of
@types/node
was missing recent changes, in particular tonode:test
, which are backported via this patch.Please fill in this template.
npm test <package to test>
.References:
run
function added in node: Addrun
function to 'node:test' #62211test
comments #62403