node: Add missing typings for AbortSignal in node

[segevfiner]

Add missing typings for AbortSignal in node

This still omits the static abort * timeout methods as they are not currently declared in TypeScript's lib. Based on definitions included with TypeScript.

Fixes #60868

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/dist/latest-v18.x/docs/api/globals.html#class-abortsignal
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@segevfiner Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• 🕐 Continuous integration tests are still running
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 61412,
  "author": "segevfiner",
  "headCommitOid": "9768ac9ae2dcb726207fd45dea73286e98700c0a",
  "mergeBaseOid": "410e20e71e47ee719ec0504ee3c6b8c58245c141",
  "lastPushDate": "2022-07-22T18:33:48.000Z",
  "lastActivityDate": "2022-07-22T18:33:48.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v14/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v14/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v16/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/test/globals.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1192628755,
  "ciResult": "unknown"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@segevfiner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[segevfiner]

Bahhh. This depends on a lot of DOM types which I'm not sure what is the best way to handle. Which I guess is why this wasn't included in the first place. Duplicating them all under the NodeJS namespace perhaps? But if they change in the future...

[rangoo94]

@segevfiner, I think it's better to duplicate them in Node.js types scope. Similar to the AbortController and AbortSignal - the implementation of DOMException and other DOM types is done explicitly for Node.js (i.e. DOMException source), so it will not necessarily conform to WHATWG DOM specs.

For example, AbortController in Node.js v14.x/v15.x was not matching the WHATWG spec, and even now it has some differences.

[tilgovi]

If we copy the DOM types, we can also extend them with the statics, AbortSignal.abort and AbortSignal.timeout, because there's no need for TypeScript's DOM lib to have it if we're not depending on the DOM lib.

[segevfiner]

The problem with adding the statics is that AbortSignal is defined in the same global scope so if lib.dom.d.ts is also included, TypeScript enforces that they must match.

[tilgovi]

Understood. Thanks.

[meyfa]

Is the problem with DOM types perhaps solved now, since #59905 has been merged?