update to d3@7.4

[Fil]

Updates:

• d3-array to v3.1.6
• d3-shape to v3.1.0
• d3-hierarchy to v3.1.2
• d3-color to v3.1.0

d3-array

https://github.com/d3/d3-array/releases/tag/v3.1.6

d3.rank can now take a comparator in addition to an accessor
d3.rank, d3.sort, d3.bisector, and d3.groupSort now require comparators to have exactly two arguments.

d3-shape

https://github.com/d3/d3-shape/releases/tag/v3.1.0

Add d3.symbolsStroke.
Add d3.symbolsFill, replacing (deprecating) d3.symbols.
Add d3.symbolAsterisk.
Add d3.symbolDiamond2.
Add d3.symbolPlus.
Add d3.symbolSquare2.
Add d3.symbolTriangle2.
Add d3.symbolX.
Add d3.link.

d3-hierarchy

https://github.com/d3/d3-hierarchy/releases/tag/v3.1.2

Add stratify.path.

d3-color

https://github.com/d3/d3-color/releases/tag/v3.1.0

Add rgb.clamp and hsl.clamp. d3/d3-color#102
Add color.formatHex8. d3/d3-color#103

---

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration

If changing an existing definition:

• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@Fil Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

5 packages in this PR

• d3-array — on npm, on unpkg
  • owner-approval: @Methuselah96
  • 1 added owner: ✎@Fil
• d3-color — on npm, on unpkg
  • owner-approval: @Methuselah96
  • 1 added owner: ✎@Fil
• d3-hierarchy — on npm, on unpkg
  • owner-approval: @Methuselah96
  • 1 added owner: ✎@Fil
• d3-shape — on npm, on unpkg
  • owner-approval: @Methuselah96
  • 1 added owner: ✎@Fil
• d3 — on npm, on unpkg
  • owner-approval: @Methuselah96
  • 1 added owner: ✎@Fil

@Fil: I see that you have added yourself as an owner to several packages, are you sure you want to become an owner?

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 60427,
  "author": "Fil",
  "headCommitOid": "35db98e4645375652dffaa4d04d2b4a3799dd3d7",
  "mergeBaseOid": "8ddbf19efe34c53726e06fac519da853b8360af8",
  "lastPushDate": "2022-05-20T14:12:21.000Z",
  "lastActivityDate": "2022-05-22T15:19:10.000Z",
  "mergeOfferDate": "2022-05-20T19:46:09.000Z",
  "mergeRequestDate": "2022-05-22T15:19:10.000Z",
  "mergeRequestUser": "Fil",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "d3-array",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-array/d3-array-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-array/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "gustavderdrache",
        "borisyankov",
        "tomwanzek",
        "denisname",
        "ledragon",
        "Methuselah96"
      ],
      "addedOwners": [
        "Fil"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3-color",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-color/d3-color-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-color/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "ledragon",
        "Methuselah96"
      ],
      "addedOwners": [
        "Fil"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-hierarchy",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-hierarchy/d3-hierarchy-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-hierarchy/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [
        "Fil"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3-shape",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-shape/d3-shape-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-shape/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [
        "Fil"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [
        "Fil"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-05-20T19:45:26.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Methuselah96",
      "date": "2022-05-20T14:23:23.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1131480302,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @gustavderdrache @borisyankov @tomwanzek @denisname @Ledragon @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[Methuselah96]

Hey @Fil, glad to see you over here. The pattern I've tried to follow in the past is to one minor version of d3 per PR. That way we don't miss adding anything from previous versions and the d3 version number is as close to accurate as possible. For example, this PR adds stuff from d3 7.3 even though the published version of d3 will still only be 7.1 if this is merged.

As an example of how I've done it in the past here is: 6.4, 6.5, 6.6, 6.7, and 7.1.

If you're interested in maintaining the types consistently like that, then that would be awesome. Otherwise, I can try to pick back up the work and get the latest few versions done.

[Fil]

Meaning, if I want to update d3-shape to @3.1 (as I did here), I also need to upgrade the types for all the other modules that have had changes between d3@7.1 (last release that was "typed") and d3@7.4 (current version of D3)?

If this is correct, and double-checking https://github.com/d3/d3/releases, this means I need to update:

• d3-color: Add rgb.clamp and hsl.clamp; add color.formatHex8.
• d3-hierarchy: Add stratify.path.
• d3-array: d3.rank can now take a comparator in addition to an accessor; d3.rank, d3.sort, d3.bisector, and d3.groupSort now require comparators to have exactly two arguments.

right?

[Methuselah96]

Right, although you don't need to go to 7.4, since these d3-shape changes were made in 7.3. So the PRs I would imagine would be in this order:

• A PR for changes included in d3 7.1.1 (the d3-array changes you mentioned)
• A PR for changes included in d3 7.2 (stratify.path)
• A PR for changes included in d3 7.3 (basically this PR)
• (optionally) A PR for changes included in d3 7.4 (d3-color changes)

I'm totally willing to do the other PRs myself, this is just the easiest way for us to make sure we aren't missing any type changes. Let me know if you're up for doing the earlier versions or if you would like me to.

[Fil]

d3-array done! I'm stopping for now

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

d3-array (unpkg)

was missing the following properties:

1. scan

d3-hierarchy (unpkg)

was missing the following properties:

1. Node

Generated by 🚫 dangerJS against 35db98e

[Fil]

what is this missing "scan" property? 👀

[Fil]

@Methuselah96 : I've finally done the four modules.

• I was a bit surprised that the accessor functions in d3-hierarchy's stratify seem to be written as having 3 required parameters, where in actuality they are all optional (although I don't know what you can do if you don't use the first parameter… anyway, it still seems optional to me)?

• I don't understand what @DangerBotOSS is complaining about in the comment above

• Do you think this should be submitted as four different PRs?

[peterblazejewicz]

• I don't understand what @DangerBotOSS is complaining about in the comment above

It analyzes content of the module, it can show false positives at some scanerios. In short, it detects exported symbols in a module and compares with exported one from types. You can skip this one as a niptick, thx!

[Methuselah96]

I was a bit surprised that the accessor functions in d3-hierarchy's stratify seem to be written as having 3 required parameters, where in actuality they are all optional (although I don't know what you can do if you don't use the first parameter… anyway, it still seems optional to me)?

The parameters for callback functions that a user passes into a method are always optional and don't need to be marked as such. The user can just pass in a function that has no parameters and TypeScript considers that to match a function signature with parameters.

I don't understand what @DangerBotOSS is complaining about in the comment above

d3-array exports a deprecated scan method that's not in the documentation. Perhaps ideally it would be included in the types and marked as deprecated, but I haven't bothered to fix it.

Do you think this should be submitted as four different PRs?

No, this is fine, thanks for putting in the work.

[Methuselah96]

Can you also bump the version numbers in d3/index.d.ts?

[typescript-bot]

@Fil One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@Methuselah96 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Methuselah96]

Awesome, thanks for your work on this!

[peterblazejewicz]

@Fil thanks!

[typescript-bot]

@Fil: Everything looks good here. I am ready to merge this PR (at 35db98e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[Fil]

Ready to merge