Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-env] add import.meta.webpackContext for webpack 5.70.0+ #59414

Merged
merged 2 commits into from Apr 15, 2022
Merged

Conversation

Rhilip
Copy link
Contributor

@Rhilip Rhilip commented Mar 23, 2022

Webpack 5.70.0+ provide a new function import.meta.webpackContext, see:

this pr extends interface ImportMeta in @types/webpack-env and add webpackContext function


Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: import.meta.webpackContext
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@Rhilip Rhilip changed the title [webpack-env] add import.meta.webpackContext for 5.70.0+ [webpack-env] add import.meta.webpackContext for webpack 5.70.0+ Mar 23, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 23, 2022

@Rhilip Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59414,
  "author": "Rhilip",
  "headCommitOid": "80a955d46fd89948a292930eb6b0a7473917f967",
  "mergeBaseOid": "1e570c25a40b6ee4161618af4e0212a64e00ae9d",
  "lastPushDate": "2022-03-23T14:43:54.000Z",
  "lastActivityDate": "2022-04-15T11:05:58.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2022-04-14T03:48:39.000Z",
  "mergeRequestDate": "2022-04-15T11:05:58.000Z",
  "mergeRequestUser": "Rhilip",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "webpack-env",
      "kind": "edit",
      "files": [
        {
          "path": "types/webpack-env/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webpack-env/webpack-env-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "use-strict",
        "rhonsby"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-04-14T03:47:57.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1076454170,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @use-strict @rhonsby — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 23, 2022
@amcasey
Copy link
Contributor

amcasey commented Mar 24, 2022

Please confirm the version in the header doesn't need to be bumped.

@amcasey
Copy link
Contributor

amcasey commented Mar 24, 2022

LGTM, but I'd like to hear from an owner.

@amcasey amcasey moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 24, 2022
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 3, 2022
@typescript-bot
Copy link
Contributor

Re-ping @use-strict, @rhonsby:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 10, 2022
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @Rhilip.

(Ping @use-strict, @rhonsby.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 14, 2022
@typescript-bot
Copy link
Contributor

@Rhilip: Everything looks good here. I am ready to merge this PR (at 80a955d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@use-strict, @rhonsby: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Apr 14, 2022
@Rhilip
Copy link
Contributor Author

Rhilip commented Apr 15, 2022

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 15, 2022
@typescript-bot typescript-bot merged commit 897ba42 into DefinitelyTyped:master Apr 15, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants