[@types/react-redux] mergeProps takes DispatchProp when mapDispatchToProps is undefined or null

[saraid]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • https://github.com/reduxjs/react-redux/blob/4d384029e3fa0355e762f40409a5dac4358a3de3/src/connect/mapDispatchToProps.ts#L14-L20
  • [@types/react-redux] null mapDispatchtoProps doesn't provide correct parameter. #59297
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@saraid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• react-redux — on npm, on unpkg
  • owner-approval: @markerikson, @val1984

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❓ Continuous integration tests have gone missing
• ✅ Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59310,
  "author": "saraid",
  "headCommitOid": "1be9f03f08015160c16757c0ae36768801ad4079",
  "mergeBaseOid": "70201155ef7d49cc23a3208806765c72c97834b7",
  "lastPushDate": "2022-03-16T18:14:33.000Z",
  "lastActivityDate": "2022-04-13T22:34:51.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-redux",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-redux/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/react-redux-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "tkqubo",
        "clayne11",
        "tansongyang",
        "nicholasboll",
        "mdibyo",
        "val1984",
        "jrakotoharisoa",
        "apapirovski",
        "surgeboris",
        "soerenbf",
        "mrwolfz",
        "dylanvann",
        "Lazyuki",
        "kazuma1989",
        "megazazik",
        "jun-sheaf",
        "phryneas",
        "markerikson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-04-13T22:34:51.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "markerikson",
      "date": "2022-04-03T18:54:54.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "val1984",
      "date": "2022-04-01T20:12:02.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1069457505,
  "ciResult": "missing"
}

[typescript-bot]

🔔 @tkqubo @clayne11 @tansongyang @NicholasBoll @mDibyo @val1984 @jrakotoharisoa @apapirovski @surgeboris @soerenbf @MrWolfZ @DylanVann @Lazyuki @kazuma1989 @megazazik @jun-sheaf @phryneas @markerikson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[saraid]

I'm a little baffled about why there's no merge button. Presumably "❓ Continuous integration tests have gone missing" has something to do with that, but... I didn't remove any tests, and AFAICT, the automated Github action passed.

[typescript-bot]

Re-ping @tkqubo, @clayne11, @tansongyang, @NicholasBoll, @mDibyo, @jrakotoharisoa, @apapirovski, @surgeboris, @soerenbf, @MrWolfZ, @DylanVann, @Lazyuki, @kazuma1989, @megazazik, @jun-sheaf, @phryneas:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[val1984]

As it was already approved by @markerikson, it should be mergeable as is.

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @saraid.

(Ping @tkqubo, @clayne11, @tansongyang, @NicholasBoll, @mDibyo, @jrakotoharisoa, @apapirovski, @surgeboris, @soerenbf, @MrWolfZ, @DylanVann, @Lazyuki, @kazuma1989, @megazazik, @jun-sheaf, @phryneas.)

[saraid]

This is what I see on my screen:

Collapsed the screenshot because it'd be confusing

[jakebailey]

I have no idea what is going on with the bot or github actions, so I ran things locally and it seems fine to me.

[jakebailey]

Ok, approving wasn't enough, so I'll click the button.

[markerikson]

And FWIW I just ported this over to React-Redux v8:

reduxjs/react-redux#1897