Update types for @rails/activestorage v7.0.2

[imustafin]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: rails/rails@aaa6468#diff-544a39d8373af5b4e345d2807b94b3113fc3e919364b4ca4bf0a8e081ac7fcf1L611-L618
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

This PR basically reverts #57781 (following rails/rails#44287).

Relevant discussion: #59071

@Oleksii14 and @AlfonsoUceda, please review this PR if you can.

Versioning

The original package @rails/activestorage has bumped its patch version with a breaking change. In DT we can't specify that typings are for 7.0.2 and not for >= 7.0.0, < 7.0.2. In DT we can only specify the major and minor versions.

Basically, users of @types/rails__activestorage should somehow understand themselves which version they need.

@sandersn, sorry for disturbing (didn't know whom to ask). Can you please clarify this?

Just wanted to confirm because this was not mentioned explicitly [enough] in the readme 😱

[typescript-bot]

@imustafin Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• rails__activestorage — on npm, on unpkg (author is owner)

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59098,
  "author": "imustafin",
  "headCommitOid": "15afda891ecd047d5c24ae203173d84b4d13c6da",
  "mergeBaseOid": "3320c953b238a6f8a3f45c8178133f39ba52a082",
  "lastPushDate": "2022-03-03T18:11:09.000Z",
  "lastActivityDate": "2022-03-21T20:07:17.000Z",
  "mergeOfferDate": "2022-03-21T19:56:12.000Z",
  "mergeRequestDate": "2022-03-21T20:07:17.000Z",
  "mergeRequestUser": "imustafin",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "rails__activestorage",
      "kind": "edit",
      "files": [
        {
          "path": "types/rails__activestorage/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rails__activestorage/rails__activestorage-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "imustafin",
        "cbothner"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "AlfonsoUceda",
      "date": "2022-03-21T19:55:32.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1058356769,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @cbothner — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

rails__activestorage (unpkg)

was missing the following properties:

1. The declaration doesn't match the JavaScript module 'rails__activestorage'. Reason:
   The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

1. hash
2. hashBinary
3. ArrayBuffer

Generated by 🚫 dangerJS against 15afda8

[sandersn]

I don't think there's any good way to do this within DT's publishing setup because it really assumes that only major.minor matters. Would a comment in the package source help? Probably not many people would think to look there, though.

[typescript-bot]

Re-ping @cbothner:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @imustafin.

(Ping @cbothner.)

[typescript-bot]

@imustafin: Everything looks good here. I am ready to merge this PR (at 15afda8) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@cbothner: you can do this too.)

[imustafin]

Ready to merge