Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Add property cwd to LintResultData #58214

Merged
merged 1 commit into from Jan 19, 2022
Merged

[eslint] Add property cwd to LintResultData #58214

merged 1 commit into from Jan 19, 2022

Conversation

fasttime
Copy link
Contributor

@fasttime fasttime commented Jan 16, 2022

Please fill in this template.

If changing an existing definition:

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Jan 16, 2022
@fasttime fasttime marked this pull request as ready for review January 16, 2022 11:19
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 16, 2022

@fasttime Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58214,
  "author": "fasttime",
  "headCommitOid": "23fa5258adfe545ee38f3897a02893c9ad30958f",
  "mergeBaseOid": "ef81b1093e53433cc3d3a45960355a846db25dc0",
  "lastPushDate": "2022-01-16T11:09:03.000Z",
  "lastActivityDate": "2022-01-16T21:47:59.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/eslint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "bradzacher",
      "date": "2022-01-16T21:47:59.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "martin-badin",
      "date": "2022-01-16T14:53:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1013857065,
  "ciResult": "pass"
}

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Jan 16, 2022
@typescript-bot
Copy link
Contributor

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Contributor

@martin-badin martin-badin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jan 16, 2022
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 16, 2022
@sandersn sandersn merged commit ae634a1 into DefinitelyTyped:master Jan 19, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jan 19, 2022
@fasttime fasttime deleted the eslint branch January 20, 2022 12:34
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants