New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint] Add property cwd
to LintResultData
#58214
Conversation
@fasttime Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58214,
"author": "fasttime",
"headCommitOid": "23fa5258adfe545ee38f3897a02893c9ad30958f",
"mergeBaseOid": "ef81b1093e53433cc3d3a45960355a846db25dc0",
"lastPushDate": "2022-01-16T11:09:03.000Z",
"lastActivityDate": "2022-01-16T21:47:59.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint",
"kind": "edit",
"files": [
{
"path": "types/eslint/eslint-tests.ts",
"kind": "test"
},
{
"path": "types/eslint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pmdartus",
"j-f1",
"saadq",
"JasonHK",
"bradzacher",
"JounQin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "bradzacher",
"date": "2022-01-16T21:47:59.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "martin-badin",
"date": "2022-01-16T14:53:24.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1013857065,
"ciResult": "pass"
} |
🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Please fill in this template.
npm test <package to test>
.If changing an existing definition: