New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove(stylelint): no longer needed #57472
remove(stylelint): no longer needed #57472
Conversation
@ybiquitous Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 13 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57472,
"author": "ybiquitous",
"headCommitOid": "0910385c873d88ac13ddf4484d6b393ad714f707",
"lastPushDate": "2021-12-02T01:48:33.000Z",
"lastActivityDate": "2021-12-16T01:53:56.000Z",
"mergeOfferDate": "2021-12-02T21:04:11.000Z",
"mergeRequestDate": "2021-12-16T01:53:56.000Z",
"mergeRequestUser": "ybiquitous",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "stylelint",
"kind": "delete",
"files": [
{
"path": "types/stylelint/index.d.ts",
"kind": "definition"
},
{
"path": "types/stylelint/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/stylelint/stylelint-tests.ts",
"kind": "test"
},
{
"path": "types/stylelint/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/stylelint/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/stylelint/v7/index.d.ts",
"kind": "definition"
},
{
"path": "types/stylelint/v7/stylelint-tests.ts",
"kind": "test"
},
{
"path": "types/stylelint/v7/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/stylelint/v7/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"alan-agius4",
"filipsalpe",
"43081j",
"bmatcuk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-12-02T21:03:31.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "bmatcuk",
"date": "2021-12-02T13:39:36.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "alan-agius4",
"date": "2021-12-02T05:23:08.000Z",
"isMaintainer": false
},
{
"type": "stale",
"reviewer": "filipsalpe",
"date": "2021-12-01T17:04:58.000Z",
"abbrOid": "b6b0379"
}
],
"mainBotCommentID": 983703984,
"ciResult": "pass"
} |
🔔 @alan-agius4 @filipsalpe @43081j @bmatcuk — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi there, thank you for the review! Ready to merge. |
@ybiquitous Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
`stylelint@14.0.0` has added its type definitions. See below: - https://github.com/stylelint/stylelint/releases/tag/14.0.0 - stylelint/stylelint#5582
@peterblazejewicz, @filipsalpe, @bmatcuk, @alan-agius4 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@peterblazejewicz, @filipsalpe, @bmatcuk Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@peterblazejewicz, @filipsalpe Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@ybiquitous: Everything looks good here. I am ready to merge this PR (at 0910385) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@alan-agius4, @filipsalpe, @43081j, @bmatcuk: you can do this too.) |
@filipsalpe Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Re-ping @ybiquitous / @filipsalpe, @43081j: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jan 1st (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
Ready to merge |
stylelint@14.0.0
has added its type definitions. See below:Note: This change is created by the
npm run not-needed -- stylelint 14.0.0
command.Please fill in this template.
npm test <package to test>
.If removing a declaration:
notNeededPackages.json
.