Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove(stylelint): no longer needed #57472

Merged
merged 1 commit into from Dec 16, 2021
Merged

remove(stylelint): no longer needed #57472

merged 1 commit into from Dec 16, 2021

Conversation

ybiquitous
Copy link
Contributor

stylelint@14.0.0 has added its type definitions. See below:

Note: This change is created by the npm run not-needed -- stylelint 14.0.0 command.

Please fill in this template.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 1, 2021

@ybiquitous Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 13 days — please merge or say something if there's a problem, otherwise it will be closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57472,
  "author": "ybiquitous",
  "headCommitOid": "0910385c873d88ac13ddf4484d6b393ad714f707",
  "lastPushDate": "2021-12-02T01:48:33.000Z",
  "lastActivityDate": "2021-12-16T01:53:56.000Z",
  "mergeOfferDate": "2021-12-02T21:04:11.000Z",
  "mergeRequestDate": "2021-12-16T01:53:56.000Z",
  "mergeRequestUser": "ybiquitous",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "stylelint",
      "kind": "delete",
      "files": [
        {
          "path": "types/stylelint/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/stylelint/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/stylelint/stylelint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/stylelint/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/stylelint/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/stylelint/v7/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/stylelint/v7/stylelint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/stylelint/v7/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/stylelint/v7/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "alan-agius4",
        "filipsalpe",
        "43081j",
        "bmatcuk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-12-02T21:03:31.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "bmatcuk",
      "date": "2021-12-02T13:39:36.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "alan-agius4",
      "date": "2021-12-02T05:23:08.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "filipsalpe",
      "date": "2021-12-01T17:04:58.000Z",
      "abbrOid": "b6b0379"
    }
  ],
  "mainBotCommentID": 983703984,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure labels Dec 1, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 1, 2021
@typescript-bot
Copy link
Contributor

🔔 @alan-agius4 @filipsalpe @43081j @bmatcuk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Dec 1, 2021
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Dec 1, 2021
Copy link
Contributor

@bmatcuk bmatcuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@filips-alpe filips-alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 1, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Dec 1, 2021
@ybiquitous
Copy link
Contributor Author

Hi there, thank you for the review!

Ready to merge.

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 2, 2021
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Needs Author Action in New Pull Request Status Board Dec 2, 2021
@typescript-bot
Copy link
Contributor

@ybiquitous Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. Maintainer Approved labels Dec 2, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Dec 2, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Dec 2, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz, @filipsalpe, @bmatcuk, @alan-agius4 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot
Copy link
Contributor

@peterblazejewicz, @filipsalpe, @bmatcuk Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Dec 2, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz, @filipsalpe Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 2, 2021
@typescript-bot
Copy link
Contributor

@ybiquitous: Everything looks good here. I am ready to merge this PR (at 0910385) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alan-agius4, @filipsalpe, @43081j, @bmatcuk: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Dec 2, 2021
@typescript-bot
Copy link
Contributor

@filipsalpe Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 16, 2021
@typescript-bot
Copy link
Contributor

Re-ping @ybiquitous / @filipsalpe, @43081j:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jan 1st (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

@ybiquitous
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Dec 16, 2021
@typescript-bot typescript-bot merged commit e87424a into DefinitelyTyped:master Dec 16, 2021
@ybiquitous ybiquitous deleted the remove-stylelint branch December 16, 2021 01:57
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants