Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-utils): fix types and add generics #57212

Merged
merged 1 commit into from Nov 18, 2021

Conversation

roikoren755
Copy link
Contributor

@roikoren755 roikoren755 commented Nov 17, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: source code. Similar discussion in @typescript-eslint's repo.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 17, 2021

@roikoren755 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57212,
  "author": "roikoren755",
  "headCommitOid": "b0b6b446cc100d1730c498d44a9d535f314dde87",
  "lastPushDate": "2021-11-17T12:16:33.000Z",
  "lastActivityDate": "2021-11-18T07:17:15.000Z",
  "mergeOfferDate": "2021-11-17T15:29:57.000Z",
  "mergeRequestDate": "2021-11-18T07:17:15.000Z",
  "mergeRequestUser": "roikoren755",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "eslint-utils",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint-utils/referenceTracker.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/eslint-utils/test/reference-tracker.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JoshuaKGoldberg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ota-meshi",
      "date": "2021-11-18T00:35:53.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "JoshuaKGoldberg",
      "date": "2021-11-17T15:29:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 971526608,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Nov 17, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Nov 17, 2021
@typescript-bot
Copy link
Contributor

🔔 @JoshuaKGoldberg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thanks!), but I'm no expert on eslint-utils. Someone from #53803 / @bradzacher / @mysticatea might want to take a look.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 17, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Nov 17, 2021
@typescript-bot
Copy link
Contributor

@roikoren755: Everything looks good here. I am ready to merge this PR (at b0b6b44) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@JoshuaKGoldberg: you can do this too.)

@roikoren755
Copy link
Contributor Author

@JoshuaKGoldberg thanks for reviewing, I'll wait for another approval before merging :)

@ota-meshi @MichaelDeBoey in case you want to look at this

Copy link
Contributor

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Nov 18, 2021
@roikoren755
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Nov 18, 2021
@typescript-bot typescript-bot merged commit a4ab0fa into DefinitelyTyped:master Nov 18, 2021
@roikoren755 roikoren755 deleted the eslint-utils-fix branch November 18, 2021 08:18
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants