New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(validator.js): v13.7 #56944
update(validator.js): v13.7 #56944
Conversation
1343ed3
to
3fbe0e1
Compare
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 6 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56944,
"author": "peterblazejewicz",
"headCommitOid": "2016578e8c5b82ff09a796940ec52287b9003279",
"lastPushDate": "2021-11-03T21:30:35.000Z",
"lastActivityDate": "2021-11-15T16:54:53.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-11-08T17:43:27.000Z",
"mergeRequestDate": "2021-11-15T16:54:53.000Z",
"mergeRequestUser": "peterblazejewicz",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "validator",
"kind": "edit",
"files": [
{
"path": "types/validator/es/lib/isBoolean.d.ts",
"kind": "definition"
},
{
"path": "types/validator/es/lib/isEmail.d.ts",
"kind": "definition"
},
{
"path": "types/validator/es/lib/isFQDN.d.ts",
"kind": "definition"
},
{
"path": "types/validator/es/lib/isIBAN.d.ts",
"kind": "definition"
},
{
"path": "types/validator/es/lib/isISO4217.d.ts",
"kind": "definition"
},
{
"path": "types/validator/es/lib/isURL.d.ts",
"kind": "definition"
},
{
"path": "types/validator/index.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isBoolean.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isEmail.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isFQDN.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isIBAN.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isISO4217.d.ts",
"kind": "definition"
},
{
"path": "types/validator/lib/isURL.d.ts",
"kind": "definition"
},
{
"path": "types/validator/validator-tests.ts",
"kind": "test"
}
],
"owners": [
"tgfjt",
"chrootsu",
"IOAyman",
"louy",
"kacepe",
"deptno",
"builtinnya",
"qqilihq",
"keatz55",
"MunifTanjim",
"vlapo",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 958306648,
"ciResult": "pass"
} |
🔔 @tgfjt @chrootsu @IOAyman @louy @kacepe @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo — please review this PR in the next few days. Be sure to explicitly select |
@peterblazejewicz |
- `isISO4217` validator - `IBAN` exports country codes - `isBoolean` `loose` option - `isURL` new options - `isEmail` new option - move update content into proper modules (following source) and re-export - test updated https://github.com/validatorjs/validator.js/releases/tag/13.7.0 Thanks!
- `allow_numeric_tld` option /cc @fasenderos
3fbe0e1
to
2016578
Compare
@fasenderos amended with changes |
@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at 2016578) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@tgfjt, @chrootsu, @IOAyman, @louy, @kacepe, @deptno, @builtinnya, @qqilihq, @keatz55, @MunifTanjim, @vlapo: you can do this too.) |
When it could be merged? |
Ready to merge 💘 |
isISO4217
validatorIBAN
exports country codesisBoolean
loose
optionisURL
new optionsisEmail
new optionre-export
https://github.com/validatorjs/validator.js/releases/tag/13.7.0
Thanks!
npm test <package to test>
.