Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(validator.js): v13.7 #56944

Merged

Conversation

peterblazejewicz
Copy link
Member

  • isISO4217 validator
  • IBAN exports country codes
  • isBoolean loose option
  • isURL new options
  • isEmail new option
  • move update content into proper modules (following source) and
    re-export
  • test updated

https://github.com/validatorjs/validator.js/releases/tag/13.7.0

Thanks!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • [ x Test the change in your own code. (Compile and run.)
  • [ x Add or edit tests to reflect the change.
  • Run npm test <package to test>.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 2, 2021

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 6 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56944,
  "author": "peterblazejewicz",
  "headCommitOid": "2016578e8c5b82ff09a796940ec52287b9003279",
  "lastPushDate": "2021-11-03T21:30:35.000Z",
  "lastActivityDate": "2021-11-15T16:54:53.000Z",
  "maintainerBlessed": "Waiting for Author to Merge",
  "mergeOfferDate": "2021-11-08T17:43:27.000Z",
  "mergeRequestDate": "2021-11-15T16:54:53.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/validator/es/lib/isBoolean.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isEmail.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isFQDN.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isIBAN.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isISO4217.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isURL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isBoolean.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isEmail.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isFQDN.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isIBAN.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isISO4217.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isURL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/validator-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tgfjt",
        "chrootsu",
        "IOAyman",
        "louy",
        "kacepe",
        "deptno",
        "builtinnya",
        "qqilihq",
        "keatz55",
        "MunifTanjim",
        "vlapo",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 958306648,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Nov 2, 2021
@typescript-bot
Copy link
Contributor

🔔 @tgfjt @chrootsu @IOAyman @louy @kacepe @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Nov 2, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Nov 2, 2021
@fasenderos
Copy link

fasenderos commented Nov 3, 2021

@peterblazejewicz my PR validatorjs/validator.js#1647 was merged in v13.7. It adds the allow_wildcard option to the isFQDN validator. Moreover I see that in the types definition of the isFQDN is missing also the allow_numeric_tld option. Can you update this PR accordingly or I have to made a separate PR? Thanks

- `isISO4217` validator
- `IBAN` exports country codes
- `isBoolean` `loose` option
- `isURL` new options
- `isEmail` new option
- move update content into proper modules (following source) and
  re-export
- test updated

https://github.com/validatorjs/validator.js/releases/tag/13.7.0

Thanks!
- `allow_numeric_tld` option

/cc @fasenderos
@peterblazejewicz
Copy link
Member Author

@fasenderos amended with changes

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Nov 3, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Nov 3, 2021
@elibarzilay elibarzilay moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Nov 8, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at 2016578) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tgfjt, @chrootsu, @IOAyman, @louy, @kacepe, @deptno, @builtinnya, @qqilihq, @keatz55, @MunifTanjim, @vlapo: you can do this too.)

@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Nov 8, 2021
@n-nik
Copy link

n-nik commented Nov 15, 2021

When it could be merged?

@peterblazejewicz
Copy link
Member Author

Ready to merge 💘

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Nov 15, 2021
@typescript-bot typescript-bot merged commit 118b2d4 into DefinitelyTyped:master Nov 15, 2021
@peterblazejewicz peterblazejewicz deleted the update/validator.js branch November 15, 2021 16:59
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants