Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown-escape #56878

Merged

Conversation

LinqLover
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm test <package to test>.
  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

See palantir/tslint#4524

No idea why this is not the default behavior, though ...
@LinqLover
Copy link
Contributor Author

🔔 @LinqLover — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@kemitchell Are you interested? :)

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 29, 2021

@LinqLover Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56878,
  "author": "LinqLover",
  "headCommitOid": "c812d17557d09a0984988e6ac60b3a2b9fa63800",
  "lastPushDate": "2021-11-03T22:15:06.000Z",
  "lastActivityDate": "2021-11-04T21:48:08.000Z",
  "mergeOfferDate": "2021-11-04T20:47:38.000Z",
  "mergeRequestDate": "2021-11-04T21:48:08.000Z",
  "mergeRequestUser": "LinqLover",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "markdown-escape",
      "kind": "add",
      "files": [
        {
          "path": "types/markdown-escape/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/markdown-escape/markdown-escape-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/markdown-escape/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/markdown-escape/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "LinqLover"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-11-04T20:47:02.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "elibarzilay",
      "date": "2021-11-03T20:26:48.000Z",
      "abbrOid": "7e71946"
    }
  ],
  "mainBotCommentID": 955070796,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Check Config Changes a module config files labels Oct 29, 2021
@typescript-bot
Copy link
Contributor

🔔 @LinqLover — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 29, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 29, 2021
@LinqLover LinqLover changed the title Add/markdown escape Add markdown-escape Oct 29, 2021
@kemitchell
Copy link

@LinqLover I'm not interested. But you do you.

Unsubscribing.

@typescript-bot typescript-bot removed the Check Config Changes a module config files label Nov 3, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Nov 3, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Nov 3, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz, @elibarzilay Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@LinqLover thx!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 4, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Nov 4, 2021
@typescript-bot
Copy link
Contributor

@elibarzilay Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@LinqLover
Copy link
Contributor Author

ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Nov 4, 2021
@typescript-bot typescript-bot merged commit 41b92f7 into DefinitelyTyped:master Nov 4, 2021
@LinqLover LinqLover deleted the add/markdown-escape branch November 4, 2021 21:48
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Nov 5, 2021
@LinqLover
Copy link
Contributor Author

Will this still be accepted for hacktoberfest? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants