Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing already gone function from stylelint declaration #56514

Conversation

lucavb
Copy link
Contributor

@lucavb lucavb commented Oct 14, 2021

This removes an already removed function from the type definitions for stylelint. This function has been removed from the code in version 12. This to me feels like a breaking change since we are removing an exported function from the definition, yet it also has been removed since two major versions already, aka users have already noticed that it doesn't work. Yet, I am not sure what the procedure then is for this package. Clarification would be welcome :)

Also I ran prettier over the files and removed some | undefined since the testing stepped asked me to. You can see the message of the testing tool in the commit message.

Select one of these and delete the others:

If changing an existing definition:

Screenshot 2021-10-14 at 22 17 54

  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 14, 2021

@lucavb Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56514,
  "author": "lucavb",
  "headCommitOid": "8c8ad152744f33f6f0377075ccfcd5375c3ac7a4",
  "lastPushDate": "2021-10-14T20:43:58.000Z",
  "lastActivityDate": "2021-10-15T17:00:47.000Z",
  "mergeOfferDate": "2021-10-15T16:31:45.000Z",
  "mergeRequestDate": "2021-10-15T17:00:47.000Z",
  "mergeRequestUser": "lucavb",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "stylelint",
      "kind": "edit",
      "files": [
        {
          "path": "types/stylelint/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/stylelint/stylelint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/stylelint/v7/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/stylelint/v7/stylelint-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alan-agius4",
        "filipsalpe",
        "43081j",
        "bmatcuk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "bmatcuk",
      "date": "2021-10-15T16:31:10.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 943721888,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 14, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 14, 2021
@typescript-bot
Copy link
Contributor

🔔 @alan-agius4 @filipsalpe @43081j @bmatcuk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Contributor

@bmatcuk bmatcuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm =)

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 15, 2021
@typescript-bot
Copy link
Contributor

@lucavb: Everything looks good here. I am ready to merge this PR (at 8c8ad15) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alan-agius4, @filipsalpe, @43081j, @bmatcuk: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Oct 15, 2021
@lucavb
Copy link
Contributor Author

lucavb commented Oct 15, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 15, 2021
@typescript-bot typescript-bot merged commit 0e11115 into DefinitelyTyped:master Oct 15, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants