New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-router] Add explicit types for children #56277
[react-router] Add explicit types for children #56277
Conversation
https://reactrouter.com/web/api/Router https://reactrouter.com/native/api/NativeRouter https://reactrouter.com/web/api/HashRouter/children-node https://reactrouter.com/web/api/BrowserRouter/children-node https://reactrouter.com/web/api/StaticRouter/children-node https://reactrouter.com/web/api/MemoryRouter/children-node
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 3 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56277,
"author": "eps1lon",
"headCommitOid": "cbdce57ba423d2c3618927496c14407da329ec20",
"lastPushDate": "2021-10-06T18:29:35.000Z",
"lastActivityDate": "2021-10-06T20:28:06.000Z",
"mergeOfferDate": "2021-10-06T19:40:26.000Z",
"mergeRequestDate": "2021-10-06T20:28:06.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-router-dom",
"kind": "edit",
"files": [
{
"path": "types/react-router-dom/index.d.ts",
"kind": "definition"
}
],
"owners": [
"huy-nguyen",
"p-jackson",
"johnnyreilly",
"eps1lon",
"danielnixon",
"ynotdraw"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react-router-native",
"kind": "edit",
"files": [
{
"path": "types/react-router-native/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ezintz",
"fhelwanger"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-router",
"kind": "edit",
"files": [
{
"path": "types/react-router/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-router/ts4.0/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-router/v3/lib/Route.d.ts",
"kind": "definition"
},
{
"path": "types/react-router/v3/lib/Router.d.ts",
"kind": "definition"
}
],
"owners": [
"sergey-buturlakin",
"mrk21",
"vasek17",
"ngbrown",
"awendland",
"KostyaEsmukov",
"johnnyreilly",
"LKay",
"DovydasNavickas",
"huy-nguyen",
"grmiade",
"DaIgeb",
"egorshulga",
"rraina",
"t49tran",
"8enSmith",
"wezleytsai",
"eps1lon",
"HipsterBrown",
"pawfa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "johnnyreilly",
"date": "2021-10-06T19:39:52.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 936876868,
"ciResult": "pass"
} |
Hey @eps1lon, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @huy-nguyen @p-jackson @johnnyreilly @danielnixon @ynotdraw @ezintz @fhelwanger @sergey-buturlakin @mrk21 @vasek17 @ngbrown @awendland @KostyaEsmukov @LKay @DovydasNavickas @Grmiade @DaIgeb @egorshulga @rraina @t49tran @8enSmith @wezleytsai @HipsterBrown @pawfa — please review this PR in the next few days. Be sure to explicitly select |
@eps1lon: Everything looks good here. I am ready to merge this PR (at cbdce57) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
We plan to remove implicit children from
@types/react
. The following changes are required to pass #56210.https://reactrouter.com/web/api/Router
https://reactrouter.com/native/api/NativeRouter
https://reactrouter.com/web/api/HashRouter/children-node
https://reactrouter.com/web/api/BrowserRouter/children-node
https://reactrouter.com/web/api/StaticRouter/children-node
https://reactrouter.com/web/api/MemoryRouter/children-node