Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-sidebar] Add explicit types for children #56274

Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 6, 2021

We plan to remove implicit children from @types/react. The following changes are required to pass #56210.

https://www.npmjs.com/package/react-sidebar/v/3.0.2#getting-started

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Oct 6, 2021
@eps1lon eps1lon marked this pull request as ready for review October 6, 2021 18:39
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 6, 2021

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56274,
  "author": "eps1lon",
  "headCommitOid": "b66c88c3bd5f8d07423baaf10c9755d6f09a0ea5",
  "lastPushDate": "2021-10-06T18:27:16.000Z",
  "lastActivityDate": "2021-10-06T18:39:00.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-sidebar",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-sidebar/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jeroenvervaeke"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 936876338,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Oct 6, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Oct 6, 2021
@typescript-bot
Copy link
Contributor

🔔 @jeroenvervaeke — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@gabritto gabritto merged commit b9c0ad4 into DefinitelyTyped:master Oct 7, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Oct 7, 2021
@eps1lon eps1lon deleted the fix/implicit-children/react-sidebar branch October 8, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants