New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-svg-pan-zoom] Add explicit types for ReactSwipe#children #56268
[react-svg-pan-zoom] Add explicit types for ReactSwipe#children #56268
Conversation
6912f6a
to
5f49ab5
Compare
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 21 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56268,
"author": "eps1lon",
"headCommitOid": "5f49ab54d96a1f388bec527189f2d9381bb62a1b",
"lastPushDate": "2021-10-06T18:22:50.000Z",
"lastActivityDate": "2021-10-07T08:51:42.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-svg-pan-zoom",
"kind": "edit",
"files": [
{
"path": "types/react-svg-pan-zoom/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-svg-pan-zoom/react-svg-pan-zoom-tests.tsx",
"kind": "test"
}
],
"owners": [
"huy-nguyen"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 937588373,
"ciResult": "pass"
} |
🔔 @huy-nguyen — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @huy-nguyen: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @eps1lon. (Ping @huy-nguyen.) |
This makes sense to me 👍🏻 |
We plan to remove implicit children from
@types/react
. The following changes are required to pass #56210.https://github.com/chrvadala/react-svg-pan-zoom/blob/v3.3.0/src/viewer.js#L603-L623