Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-svg-pan-zoom] Add explicit types for ReactSwipe#children #56268

Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 6, 2021

We plan to remove implicit children from @types/react. The following changes are required to pass #56210.

https://github.com/chrvadala/react-svg-pan-zoom/blob/v3.3.0/src/viewer.js#L603-L623

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Oct 6, 2021
@eps1lon eps1lon force-pushed the fix/implicit-children/react-svg-pan-zoom branch from 6912f6a to 5f49ab5 Compare October 6, 2021 18:22
@eps1lon eps1lon changed the title [react-swipe] Add explicit types for ReactSwipe#children [react-svg-pan-zoom] Add explicit types for ReactSwipe#children Oct 7, 2021
@eps1lon eps1lon marked this pull request as ready for review October 7, 2021 08:51
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 7, 2021

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 21 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56268,
  "author": "eps1lon",
  "headCommitOid": "5f49ab54d96a1f388bec527189f2d9381bb62a1b",
  "lastPushDate": "2021-10-06T18:22:50.000Z",
  "lastActivityDate": "2021-10-07T08:51:42.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-svg-pan-zoom",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-svg-pan-zoom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-svg-pan-zoom/react-svg-pan-zoom-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "huy-nguyen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 937588373,
  "ciResult": "pass"
}

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Oct 7, 2021
@typescript-bot
Copy link
Contributor

🔔 @huy-nguyen — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 17, 2021
@typescript-bot
Copy link
Contributor

Re-ping @huy-nguyen:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @eps1lon.

(Ping @huy-nguyen.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 24, 2021
@orta
Copy link
Collaborator

orta commented Oct 28, 2021

This makes sense to me 👍🏻

@orta orta merged commit fc6209f into DefinitelyTyped:master Oct 28, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Oct 28, 2021
@eps1lon eps1lon deleted the fix/implicit-children/react-svg-pan-zoom branch October 28, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants