Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-tracking] Add explicit children to TrackingComponent #56264

Merged
merged 3 commits into from
Oct 14, 2021
Merged

[react-tracking] Add explicit children to TrackingComponent #56264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64eafe1
[react-tracking] Add explicit `children` to TrackingComponent
eps1lon Oct 3, 2021
99a45a3
Apply suggestions from code review
eps1lon Oct 7, 2021
6e20b65
fix failing test
eps1lon Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/react-tracking/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface TrackingHook<P = {}> extends TrackingProp<P> {
/**
* This component will pass any tracking data as context to tracking calls made in any components within its subtree.
*/
Track: TrackingComponent<P>;
Track: TrackingComponent;
eps1lon marked this conversation as resolved.
Show resolved Hide resolved
}

type Falsy = false | null | undefined | "";
Expand Down Expand Up @@ -116,7 +116,7 @@ export interface Track<T = any, P = any, S = any> {
/**
* This component will pass any tracking data as context to tracking calls made in any components within its subtree.
*/
export type TrackingComponent<P = {}> = React.FC;
export type TrackingComponent = React.FC<React.PropsWithChildren<{}>>;
eps1lon marked this conversation as resolved.
Show resolved Hide resolved

export const track: Track;
export default track;