Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reactable] Add explicit types for children #56259

Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 6, 2021

We plan to remove implicit children from @types/react. The following changes are required to pass #56210.

https://github.com/abdulrahman-khankan/reactable/tree/0.14.1#customizing-columns

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Oct 6, 2021
@eps1lon eps1lon marked this pull request as ready for review October 7, 2021 08:52
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 7, 2021

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56259,
  "author": "eps1lon",
  "headCommitOid": "c600a3118382f303913fc067530478fe275a0d9f",
  "lastPushDate": "2021-10-06T18:14:11.000Z",
  "lastActivityDate": "2021-10-14T09:37:44.000Z",
  "mergeOfferDate": "2021-10-13T23:42:22.000Z",
  "mergeRequestDate": "2021-10-14T09:37:44.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "reactable",
      "kind": "edit",
      "files": [
        {
          "path": "types/reactable/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "spielc",
        "priscila-moneo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2021-10-13T23:41:47.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "spielc",
      "date": "2021-10-07T17:22:37.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 937589113,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Oct 7, 2021
@typescript-bot
Copy link
Contributor

Hey @eps1lon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Oct 7, 2021
@typescript-bot
Copy link
Contributor

🔔 @spielc @priscila-moneo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Contributor

@spielc spielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in my opinion...

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 7, 2021
@typescript-bot
Copy link
Contributor

⏳ Hi @eps1lon,

It's been a few days since this PR was approved by spielc and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 13, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 13, 2021
@typescript-bot
Copy link
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at c600a31) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@spielc, @priscila-moneo: you can do this too.)

@eps1lon
Copy link
Collaborator Author

eps1lon commented Oct 14, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 14, 2021
@typescript-bot typescript-bot merged commit a3329a8 into DefinitelyTyped:master Oct 14, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 14, 2021
@eps1lon eps1lon deleted the fix/reactable/implcit-children branch October 14, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants