New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Add Explicit types for children #56255
[material-ui] Add Explicit types for children #56255
Conversation
https://github.com/mui-org/material-ui/blob/v0.x/src/styles/MuiThemeProvider.js#L8 https://github.com/mui-org/material-ui/blob/v0.x/src/IconMenu/IconMenu.js#L34 https://github.com/mui-org/material-ui/blob/v0.x/src/Avatar/Avatar.js#L49 https://github.com/mui-org/material-ui/blob/v0.x/src/Badge/Badge.js#L65 https://github.com/mui-org/material-ui/blob/v0.x/src/RaisedButton/RaisedButton.js#L131 https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardMedia.js#L49 https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardText.js#L27 https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardActions.js#L25 https://github.com/mui-org/material-ui/blob/v0.x/src/Card/Card.js#L11 https://github.com/mui-org/material-ui/blob/v0.x/src/Chip/Chip.js#L56 https://github.com/mui-org/material-ui/blob/v0.x/src/RadioButton/RadioButtonGroup.js#L11 https://github.com/mui-org/material-ui/blob/v0.x/src/Menu/Menu.js#L59 https://github.com/mui-org/material-ui/blob/v0.x/src/Drawer/Drawer.js#L19 https://github.com/mui-org/material-ui/blob/v0.x/src/GridList/GridList.js#L31 https://github.com/mui-org/material-ui/blob/v0.x/src/GridList/GridTile.js#L77 https://github.com/mui-org/material-ui/blob/v0.x/src/Subheader/Subheader.js#L42 https://github.com/mui-org/material-ui/blob/v0.x/src/DropDownMenu/DropDownMenu.js#L111 https://github.com/mui-org/material-ui/blob/v0.x/src/Popover/Popover.js#L54 https://github.com/mui-org/material-ui/blob/v0.x/src/SelectField/SelectField.js#L38 https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/Stepper.js#L28 https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepLabel.js#L126 https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/Step.js#L32 https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepContent.js#L37 https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepButton.js#L40 https://github.com/mui-org/material-ui/blob/v0.x/src/Table/Table.js#L45 https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableRow.js#L33 https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableHeaderColumn.js#L30 https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableRowColumn.js#L30 https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableFooter.js#L36 https://github.com/mui-org/material-ui/blob/v0.x/src/Tabs/Tabs.js#L25 https://github.com/mui-org/material-ui/blob/v0.x/src/BottomNavigation/BottomNavigation.js#L59
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56255,
"author": "eps1lon",
"headCommitOid": "4f2fd729b4774d2041dd108ea8e1363e9c440ea0",
"lastPushDate": "2021-10-06T18:10:23.000Z",
"lastActivityDate": "2021-10-15T18:34:31.000Z",
"mergeOfferDate": "2021-10-15T18:05:12.000Z",
"mergeRequestDate": "2021-10-15T18:34:31.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "material-ui",
"kind": "edit",
"files": [
{
"path": "types/material-ui/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ngbrown",
"theigor",
"alitaheri",
"herrmanno",
"DaIgeb",
"allienna",
"schlesingermatthias",
"InsidersByte",
"artyomsv",
"dan-j",
"minodisk",
"samwalshnz",
"reggino"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "amcasey",
"date": "2021-10-15T18:04:38.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 937589386,
"ciResult": "pass"
} |
Hey @eps1lon, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @ngbrown @theigor @alitaheri @herrmanno @DaIgeb @allienna @schlesingermatthias @InsidersByte @artyomsv @dan-j @minodisk @samwalshnz @Reggino — please review this PR in the next few days. Be sure to explicitly select |
@eps1lon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@eps1lon: Everything looks good here. I am ready to merge this PR (at 4f2fd72) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@ngbrown, @theigor, @alitaheri, @herrmanno, @DaIgeb, @allienna, @schlesingermatthias, @InsidersByte, @artyomsv, @dan-j, @minodisk, @samwalshnz, @Reggino: you can do this too.) |
Ready to merge |
We plan to remove implicit children from
@types/react
. The following changes are required to pass #56210.https://github.com/mui-org/material-ui/blob/v0.x/src/styles/MuiThemeProvider.js#L8
https://github.com/mui-org/material-ui/blob/v0.x/src/IconMenu/IconMenu.js#L34
https://github.com/mui-org/material-ui/blob/v0.x/src/Avatar/Avatar.js#L49
https://github.com/mui-org/material-ui/blob/v0.x/src/Badge/Badge.js#L65
https://github.com/mui-org/material-ui/blob/v0.x/src/RaisedButton/RaisedButton.js#L131
https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardMedia.js#L49
https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardText.js#L27
https://github.com/mui-org/material-ui/blob/v0.x/src/Card/CardActions.js#L25
https://github.com/mui-org/material-ui/blob/v0.x/src/Card/Card.js#L11
https://github.com/mui-org/material-ui/blob/v0.x/src/Chip/Chip.js#L56
https://github.com/mui-org/material-ui/blob/v0.x/src/RadioButton/RadioButtonGroup.js#L11
https://github.com/mui-org/material-ui/blob/v0.x/src/Menu/Menu.js#L59
https://github.com/mui-org/material-ui/blob/v0.x/src/Drawer/Drawer.js#L19
https://github.com/mui-org/material-ui/blob/v0.x/src/GridList/GridList.js#L31
https://github.com/mui-org/material-ui/blob/v0.x/src/GridList/GridTile.js#L77
https://github.com/mui-org/material-ui/blob/v0.x/src/Subheader/Subheader.js#L42
https://github.com/mui-org/material-ui/blob/v0.x/src/DropDownMenu/DropDownMenu.js#L111
https://github.com/mui-org/material-ui/blob/v0.x/src/Popover/Popover.js#L54
https://github.com/mui-org/material-ui/blob/v0.x/src/SelectField/SelectField.js#L38
https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/Stepper.js#L28
https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepLabel.js#L126
https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/Step.js#L32
https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepContent.js#L37
https://github.com/mui-org/material-ui/blob/v0.x/src/Stepper/StepButton.js#L40
https://github.com/mui-org/material-ui/blob/v0.x/src/Table/Table.js#L45
https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableRow.js#L33
https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableHeaderColumn.js#L30
https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableRowColumn.js#L30
https://github.com/mui-org/material-ui/blob/v0.x/src/Table/TableFooter.js#L36
https://github.com/mui-org/material-ui/blob/v0.x/src/Tabs/Tabs.js#L25
https://github.com/mui-org/material-ui/blob/v0.x/src/BottomNavigation/BottomNavigation.js#L59