Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-fetch): Change incorrect [string] to string #54674

Merged
merged 1 commit into from Jul 22, 2021

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jul 22, 2021

The current definition for Headers has values(): IterableIterator<[string]>. The implementation is actually values(): IterableIterator<string> (spec compliant).

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2021

@wjhsf Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54674,
  "author": "wjhsf",
  "headCommitOid": "7fca3a4a3a21e46912017ce54e4dce87916da0bc",
  "lastPushDate": "2021-07-22T02:24:04.000Z",
  "lastActivityDate": "2021-07-22T10:03:31.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-fetch/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node-fetch/node-fetch-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "torstenwerner",
        "nikcorg",
        "vinaybedre",
        "kyranet",
        "AndrewLeedham",
        "JasonLi914",
        "southpolesteve",
        "ExE-Boss",
        "alexandrusavin",
        "OmgImAlexis",
        "kbkk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "AndrewLeedham",
      "date": "2021-07-22T10:03:31.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "nikcorg",
      "date": "2021-07-22T09:18:32.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "kyranet",
      "date": "2021-07-22T08:25:26.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "OmgImAlexis",
      "date": "2021-07-22T02:35:12.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 884618007,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @torstenwerner @nikcorg @vinaybedre @kyranet @AndrewLeedham @JasonLi914 @southpolesteve @ExE-Boss @alexandrusavin @OmgImAlexis @kbkk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@OmgImAlexis
Copy link
Contributor

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 22, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 22, 2021
@weswigham weswigham merged commit a217b44 into DefinitelyTyped:master Jul 22, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jul 22, 2021
@typescript-bot
Copy link
Contributor

I just published @types/node-fetch@2.5.12 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants