Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): add Context#getPhysicalFilename method #54419

Merged
merged 1 commit into from Jul 12, 2021
Merged

feat(eslint): add Context#getPhysicalFilename method #54419

merged 1 commit into from Jul 12, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jul 10, 2021

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 10, 2021

@JounQin Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54419,
  "author": "JounQin",
  "headCommitOid": "4a6cb7d29e87446809332bce910ece7e7e13e6f7",
  "lastPushDate": "2021-07-10T08:58:00.000Z",
  "lastActivityDate": "2021-07-12T23:44:32.000Z",
  "maintainerBlessed": "Waiting for Author to Merge",
  "mergeOfferDate": "2021-07-12T22:02:19.000Z",
  "mergeRequestDate": "2021-07-12T23:44:32.000Z",
  "mergeRequestUser": "JounQin",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/eslint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 877600832,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Jul 10, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jul 10, 2021
@typescript-bot
Copy link
Contributor

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 10, 2021
@elibarzilay elibarzilay moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Jul 12, 2021
@typescript-bot
Copy link
Contributor

@JounQin: Everything looks good here. I am ready to merge this PR (at 4a6cb7d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher: you can do this too.)

@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Jul 12, 2021
@JounQin
Copy link
Contributor Author

JounQin commented Jul 12, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jul 12, 2021
@typescript-bot typescript-bot merged commit a3d1522 into DefinitelyTyped:master Jul 12, 2021
@JounQin JounQin deleted the eslint branch July 12, 2021 23:53
@typescript-bot
Copy link
Contributor

I just published @types/eslint@7.28.0 to npm.

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants