Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] add cacheStategy option #53485

Merged
merged 3 commits into from Jun 1, 2021
Merged

[eslint] add cacheStategy option #53485

merged 3 commits into from Jun 1, 2021

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented May 29, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board May 29, 2021
@rafaelss95 rafaelss95 marked this pull request as ready for review May 29, 2021 01:02
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board May 29, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented May 29, 2021

@rafaelss95 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes in this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53485,
  "author": "rafaelss95",
  "headCommitOid": "afc4a0b822bde69628b8689b498b3b9832607fe2",
  "lastPushDate": "2021-05-29T00:56:58.000Z",
  "lastActivityDate": "2021-06-01T21:25:11.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2021-06-01T21:12:18.000Z",
  "mergeRequestDate": "2021-06-01T21:25:11.000Z",
  "mergeRequestUser": "rafaelss95",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/eslint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "JounQin",
      "date": "2021-05-29T01:52:43.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 850741041,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 29, 2021
@RyanCavanaugh RyanCavanaugh moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jun 1, 2021
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Jun 1, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Jun 1, 2021
@typescript-bot
Copy link
Contributor

@rafaelss95 Everything looks good here. Great job! I am ready to merge this PR (at afc4a0b) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher, @JounQin: you can do this too.)

@rafaelss95
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jun 1, 2021
@typescript-bot typescript-bot merged commit c0feb58 into DefinitelyTyped:master Jun 1, 2021
@rafaelss95 rafaelss95 deleted the patch-1 branch June 1, 2021 21:27
@typescript-bot
Copy link
Contributor

I just published @types/eslint@7.2.13 to npm.

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants