feat(yargs): add types for yargs@v17

[bcoe]

yargs@17 is a major overhaul of how asynchronous commands, builders, and middleware are handled (it's now possible to await parse() and await .argv).

This should not be merged until yargs/yargs#1876 is released (once Node 10 is EOL).

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: chore: release 17.0.0 yargs/yargs#1876
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@bcoe Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• yargs — on npm, on unpkg
  • 1 added owner: ✎@bcoe
  • Config files to check:
    • yargs/v16/tslint.json: not the expected form (check: rules)

@bcoe: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52169,
  "author": "bcoe",
  "headCommitOid": "291405ff143eb82ec9e3f1e11176f349a75c716c",
  "lastPushDate": "2021-05-21T00:33:35.000Z",
  "lastActivityDate": "2021-05-21T00:33:35.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "yargs",
      "kind": "edit",
      "files": [
        {
          "path": "types/yargs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/v16/helpers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/v16/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/yargs/v16/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        },
        {
          "path": "types/yargs/v16/yargs-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/yargs/v16/yargs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/yargs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "poelstra",
        "mizunashi-mana",
        "pushplay",
        "JimiC",
        "steffenvv",
        "forivall",
        "ExE-Boss",
        "Aankhen"
      ],
      "addedOwners": [
        "bcoe"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @poelstra @mizunashi-mana @pushplay @JimiC @steffenvv @forivall @ExE-Boss @Aankhen — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@bcoe Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@bcoe The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@bcoe The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of yargs that doesn’t yet exist on master, so I’ve compared them with v16.0.

Comparison details 📊

	16.0@master	17.0 in #52169	diff
Batch compilation
Memory usage (MiB)	87.7	89.2	+1.8%
Type count	16984	17408	+2%
Assignability cache size	3010	3061	+2%
Language service
Samples taken	1578	1546	-2%
Identifiers in tests	1578	1546	-2%
getCompletionsAtPosition
Mean duration (ms)	374.3	367.8	-1.7%
Mean CV	9.5%	9.0%
Worst duration (ms)	721.3	762.9	+5.8%
Worst identifier	yargs	array
getQuickInfoAtPosition
Mean duration (ms)	371.4	366.5	-1.3%
Mean CV	9.3%	9.0%
Worst duration (ms)	698.3	750.7	+7.5%
Worst identifier	positional	default

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[bcoe]

this issue is tracking the additional work to be done for yargs@v17.

[typescript-bot]

Re-ping @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @forivall, @ExE-Boss, @Aankhen:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[forivall]

Please mark the PR as "Draft" status in github so that wee ol' typescript-bot knows it's still WIP!

[bcoe]

@forivall just released v17 of yargs, the bulk of the changes relate to handling of asynchronous behavior.

[typescript-bot]

Re-ping @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @forivall, @ExE-Boss, @Aankhen:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

@bcoe Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @bcoe.

(Ping @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @forivall, @ExE-Boss, @Aankhen.)

[typescript-bot]

I just published @types/yargs@17.0.0 to npm.

[typescript-bot]

I just published @types/yargs@16.0.3 to npm.