Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[papaparse] add chunkSize to ParseConfig #46280

Merged
merged 1 commit into from Jul 26, 2020
Merged

[papaparse] add chunkSize to ParseConfig #46280

merged 1 commit into from Jul 26, 2020

Conversation

akshaybabloo
Copy link
Contributor

@akshaybabloo akshaybabloo commented Jul 23, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: chunkSize documented mholt/PapaParse#818
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jul 23, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 23, 2020

@akshaybabloo Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 46280,
  "author": "akshaybabloo",
  "owners": [
    "torpedro",
    "rainshen49",
    "jfloff",
    "johnnyreilly",
    "albertorestifo",
    "BehindTheMath",
    "3af",
    "jliuhtonen",
    "rbarbazz"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "2ef5668",
  "headCommitOid": "2ef566886f92de204e88a0c07828b760e6265c22",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-23T04:56:14.000Z",
  "lastCommentDate": "2020-07-26T08:21:42.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46280/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "papaparse"
  ],
  "files": [
    {
      "path": "types/papaparse/index.d.ts",
      "kind": "definition",
      "package": "papaparse"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @torpedro @rainshen49 @jfloff @johnnyreilly @albertorestifo @BehindTheMath @3af @jliuhtonen @rbarbazz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@danger-public
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

papaparse (unpkg)

was missing the following properties:

  1. BYTE_ORDER_MARK
  2. BAD_DELIMITERS
  3. ParserHandle
  4. NetworkStreamer
  5. FileStreamer
as well as these 3 other properties...

StringStreamer, ReadableStreamStreamer, DuplexStreamStreamer

Generated by 🚫 dangerJS against 2ef5668

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jul 23, 2020
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Jul 23, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 23, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #46280 diff
Batch compilation
Memory usage (MiB) 94.1 95.2 +1.1%
Type count 15332 15332 0%
Assignability cache size 3696 3696 0%
Language service
Samples taken 164 164 0%
Identifiers in tests 164 164 0%
getCompletionsAtPosition
    Mean duration (ms) 555.9 566.4 +1.9%
    Mean CV 6.8% 9.0%
    Worst duration (ms) 655.8 703.9 +7.3%
    Worst identifier Papa Papa
getQuickInfoAtPosition
    Mean duration (ms) 576.4 567.3 -1.6%
    Mean CV 11.1% 9.3% -16.4%
    Worst duration (ms) 699.3 704.2 +0.7%
    Worst identifier Papa parse

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 23, 2020
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jul 23, 2020
@akshaybabloo
Copy link
Contributor Author

Any update on this please?

@johnnyreilly johnnyreilly merged commit 42b52c8 into DefinitelyTyped:master Jul 26, 2020
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board Jul 26, 2020
@typescript-bot
Copy link
Contributor

I just published @types/papaparse@5.0.6 to npm.

astorije pushed a commit to astorije/DefinitelyTyped that referenced this pull request Jul 30, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants