New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated transformHeader function input type #46197
Conversation
@jbcam Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46197,
"author": "jbcam",
"owners": [
"torpedro",
"rainshen49",
"jfloff",
"johnnyreilly",
"albertorestifo",
"BehindTheMath",
"3af",
"jliuhtonen",
"rbarbazz"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "57db620",
"headCommitOid": "57db620947be0e68a77632ca098e496c682d835a",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-07-20T11:24:47.000Z",
"lastCommentDate": "2020-07-20T11:36:33.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46197/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"papaparse"
],
"files": [
{
"path": "types/papaparse/index.d.ts",
"kind": "definition",
"package": "papaparse"
},
{
"path": "types/papaparse/papaparse-tests.ts",
"kind": "test",
"package": "papaparse"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @torpedro @rainshen49 @jfloff @johnnyreilly @albertorestifo @BehindTheMath @3af @jliuhtonen @rbarbazz — please review this PR in the next few days. Be sure to explicitly select |
types/papaparse/papaparse-tests.ts
Outdated
transform: function(value, field) {}, | ||
transformHeader: function(header) { | ||
transform: function (value, field) {}, | ||
transformHeader: function (header, index) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual change is located here, everything else is linter update
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. papaparse (unpkg)was missing the following properties:
as well as these 3 other properties...StringStreamer, ReadableStreamStreamer, DuplexStreamStreamer |
57db620
to
8c9eba5
Compare
@jbcam — There was an error that prevented me from properly processing this PR:
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.