New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resolve]: update to v1.17 #44137
[resolve]: update to v1.17 #44137
Conversation
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@SimenB Thank you for submitting this PR! 🔔 @marionebl @ajafff - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
@SimenB Thank you for submitting this PR! This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44137,
"author": "SimenB",
"owners": [
"marionebl",
"ajafff"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "6e55d47",
"headCommitOid": "6e55d47cdf9f0f851d8ef097712000d646be2fcd",
"mergeIsRequested": false,
"stalenessInDays": 11,
"lastCommitDate": "2020-04-23T08:15:31.000Z",
"lastAuthorCommentDate": "2020-04-23T08:15:31.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44137/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"resolve"
],
"files": [
{
"filePath": "types/resolve/index.d.ts",
"kind": "definition",
"package": "resolve"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @marionebl @ajafff - please review this PR in the next few days. Be sure to explicitly select |
* [resolve]: update to v1.17 * chore: update comment
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
sync
/async
: addrealpath
/realpathSync
options browserify/resolve#218tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.