Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolve]: update to v1.17 #44137

Merged
merged 2 commits into from May 4, 2020
Merged

[resolve]: update to v1.17 #44137

merged 2 commits into from May 4, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 23, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44137 diff
Batch compilation
Memory usage (MiB) 68.1 68.3 +0.4%
Type count 8468 8473 0%
Assignability cache size 874 874 0%
Language service
Samples taken 161 161 0%
Identifiers in tests 161 161 0%
getCompletionsAtPosition
    Mean duration (ms) 326.5 331.4 +1.5%
    Mean CV 10.7% 11.2%
    Worst duration (ms) 422.2 394.3 -6.6%
    Worst identifier version error
getQuickInfoAtPosition
    Mean duration (ms) 329.5 333.0 +1.1%
    Mean CV 10.8% 11.5% +6.1%
    Worst duration (ms) 425.8 428.2 +0.6%
    Worst identifier paths version

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Apr 23, 2020
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Apr 23, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 23, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 23, 2020

@SimenB Thank you for submitting this PR!

🔔 @marionebl @ajafff - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added this to Needs Maintainer Review in New Pull Request Status Board Apr 30, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 30, 2020

@SimenB Thank you for submitting this PR!

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44137,
  "author": "SimenB",
  "owners": [
    "marionebl",
    "ajafff"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "6e55d47",
  "headCommitOid": "6e55d47cdf9f0f851d8ef097712000d646be2fcd",
  "mergeIsRequested": false,
  "stalenessInDays": 11,
  "lastCommitDate": "2020-04-23T08:15:31.000Z",
  "lastAuthorCommentDate": "2020-04-23T08:15:31.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44137/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "resolve"
  ],
  "files": [
    {
      "filePath": "types/resolve/index.d.ts",
      "kind": "definition",
      "package": "resolve"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @marionebl @ajafff - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@weswigham weswigham merged commit daf6457 into DefinitelyTyped:master May 4, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 4, 2020
@SimenB SimenB deleted the patch-1 branch May 5, 2020 08:04
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
* [resolve]: update to v1.17

* chore: update comment
@elibarzilay elibarzilay removed this from Waiting for Reviewers in Pull Request Status Board Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants