Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] Port ElementRef utility type from Flow #43201

Merged
merged 10 commits into from Mar 20, 2020
Merged

[react] Port ElementRef utility type from Flow #43201

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
de1592a
[react] Port ElementRef utility type from Flow
alloy Mar 18, 2020
d66bc4c
[react] Use least amount of required typing
alloy Mar 18, 2020
b92bf40
[react] Support forwarded refs with ElementRef
alloy Mar 18, 2020
4e5d625
[react] Use correct function component return type
alloy Mar 18, 2020
6b54006
[react] Add ElementRef test for memoized ref forwarding component
alloy Mar 19, 2020
5fa3e17
[react] Add ElementRef test for lazy component
alloy Mar 19, 2020
333a97a
[react] Match function components with props
alloy Mar 19, 2020
ce83070
[react] Fix test-case by moving type around
alloy Mar 19, 2020
31151a2
[react] Fix flaky test-case
alloy Mar 19, 2020
bce5bbc
[recharts] Remove deprecated CSS properties
alloy Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/react/index.d.ts
View file
Open in desktop
Expand Up @@ -82,8 +82,6 @@ declare namespace React {
| ((props: P) => ReactElement | null)
| (new (props: P) => Component<P, any>);

type Key = string | number;

interface RefObject<T> {
readonly current: T | null;
}
Expand Down Expand Up @@ -129,6 +127,8 @@ declare namespace React {

type ComponentState = any;

type Key = string | number;

alloy marked this conversation as resolved.
Show resolved Hide resolved
/**
* @internal You shouldn't need to use this type since you never see these attributes
* inside your component or have to validate them.
Expand Down