Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from react-dom as it doesn't exist. #42072

Closed
wants to merge 1 commit into from

Conversation

ealush
Copy link

@ealush ealush commented Feb 3, 2020

Removing the version property from react-dom client entry as it doesn't exist and it hasn't been there since version 16.0.0.
facebook/react#15780

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

@ealush ealush closed this Feb 3, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42072 diff
Batch compilation
Memory usage (MiB) 120.4 121.1 +0.6%
Type count 23704 23704 0%
Assignability cache size 53713 53713 0%
Language service
Samples taken 422 422 0%
Identifiers in tests 422 422 0%
getCompletionsAtPosition
    Mean duration (ms) 526.6 529.1 +0.5%
    Mean CV 8.2% 8.5%
    Worst duration (ms) 690.9 691.3 +0.1%
    Worst identifier React rootElement
getQuickInfoAtPosition
    Mean duration (ms) 526.2 525.1 -0.2%
    Mean CV 8.6% 8.3% -3.6%
    Worst duration (ms) 723.2 669.3 -7.4%
    Worst identifier renderIntoDocument element

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants