Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-dev-server): contentBasePublicPath from v3.10 #41962

Merged

Conversation

peterblazejewicz
Copy link
Member

  • property added
  • test update
  • version bump

Thanks!

Please fill in this template.

- property added
- test update
- version bump

Thanks!
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #41962 diff
Batch compilation
Memory usage (MiB) 72.8 70.8 -2.7%
Type count 11291 11293 0%
Assignability cache size 1436 1436 0%
Language service
Samples taken 127 128 +1%
Identifiers in tests 127 128 +1%
getCompletionsAtPosition
    Mean duration (ms) 409.2 412.6 +0.8%
    Mean CV 9.6% 9.6%
    Worst duration (ms) 509.8 577.6 +13.3%
    Worst identifier custom json
getQuickInfoAtPosition
    Mean duration (ms) 412.5 413.1 +0.1%
    Mean CV 10.2% 10.2% 0.0%
    Worst duration (ms) 518.6 507.3 -2.2%
    Worst identifier get res

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jan 29, 2020
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jan 29, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jan 29, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 29, 2020

@peterblazejewicz Thank you for submitting this PR!

🔔 @maestroh @daveparslow @ZheyangSong @alan-agius4 @arturovt @davecardwell @dobogo @billy-le @chrispaterson - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@chrispaterson chrispaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jan 29, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jan 29, 2020
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@weswigham weswigham merged commit cca9809 into DefinitelyTyped:master Jan 30, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Jan 30, 2020
@peterblazejewicz peterblazejewicz deleted the feat/webpack-dev-server branch January 30, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants