[sharp] Update typings to 0.23

[fdebijl]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • Add smartSubsample and reductionEffort parameters to Webpoptions: WebP: expose the 'method' encoding parameter lovell/sharp#1545
  • Remove cutout parameter from OverlayOptions: https://github.com/lovell/sharp/blob/master/lib/composite.js#L72 (This parameter is not mentioned in the changelogs, but seemingly not present)
  • Add premultiplied parameter to OverlayOptions: Add premultiplied option to composite lovell/sharp#1835
  • Add skipBlanks parameter to TileOptions: add skipBlanks support for dz and zoomify layout lovell/sharp#1687
  • Change layout parameter in TileOptions to a union type. I believe a union type is more apt for layout since only three string values are valid. Blend also uses a 16-string union type, so using one for the layout makes more sense than string in my opinion.
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@fdebijl Thank you for submitting this PR!

🔔 @lith-light-g @wooseopkim @BTOdell @JamieWoodbury - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of sharp that doesn’t yet exist on master, so I’ve compared them with v0.

Comparison details 📊

	0@master	* in #39001	diff
Batch compilation
Type count	9326	9700	+4%
Assignability cache size	2938	3167	+8%
Language service
Samples taken	1775	355	-80%
Identifiers in tests	355	355	0%
getCompletionsAtPosition
Mean duration (ms)	388.8	391.8	+0.8%
Mean CV		12.7%
Worst duration (ms)	507.3	490.4	-3.3%
Worst identifier	toBuffer	background
getQuickInfoAtPosition
Mean duration (ms)	420.4	403.9	-3.9%
Mean CV		13.3%
Worst duration (ms)	519.7	519.8	0.0%
Worst identifier	position	right
System information
Node version		v10.16.3
CPU count	2	2
CPU speed	2.394 GHz	2.294 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1041-azure	4.15.0-1059-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[fdebijl]

More testing in my current project revealed that the parameters for the composite method are also outdated, Create should be a property of input when used instead of a string or Buffer. See the parameter list at https://sharp.pixelplumbing.com/en/stable/api-composite/ and https://github.com/lovell/sharp/blob/master/lib/composite.js#L72

I changed it into input?: string | Buffer | {create: Create};, but maybe that should be a separate type - someone more experienced with TS best practices will have to make that call.

A 100x100px black square being created as intended using the new typings.

[typescript-bot]

Updated numbers for you here from ac2549a.

Comparison details 📊

	master	#39001	diff
Batch compilation
Memory usage (MiB)	67.8	66.9	-1.4%
Type count	9808	9815	0%
Assignability cache size	3200	3199	0%
Language service
Samples taken	355	355	0%
Identifiers in tests	355	355	0%
getCompletionsAtPosition
Mean duration (ms)	354.4	349.2	-1.5%
Mean CV	12.3%	12.3%
Worst duration (ms)	452.8	471.0	+4.0%
Worst identifier	webp	extend
getQuickInfoAtPosition
Mean duration (ms)	363.3	357.3	-1.7%
Mean CV	13.3%	13.2%	-0.8%
Worst duration (ms)	456.7	429.5	-6.0%
Worst identifier	toBuffer	top

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

[andrewbranch]

Looks good, thanks!