Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React.Attributes
is not meant to be used that way since it includes props that you never see inside your component or need to validate withpropTypes
. It's technically only a private type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is broken without
extends React.Attributes
--WeakValidationMap<AttributeProps>
doesn't have any properties in common withWeakValidationMap<RefAttributes<RefComponent>>
fromForwardRefExoticComponent<RefAttributes<RefComponent>>
Does that mean the test is broken or the new propTypes property in ForwardRefExoticComponent is wrong? I suppose I could say
in the test instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know React that well, I'm just trying to get it unblocked for other contributors, so any advice you have is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well lets merge this if this blocks other work. I'll take look later why we need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I merged it.
@rpokorny Maybe you can take another look too?