Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Add propTypes to ForwardRefExoticComponent #38337

Merged
merged 2 commits into from Sep 24, 2019

Conversation

rpokorny
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. (It doesn't)
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed. (N/A)

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Sep 12, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Sep 12, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 12, 2019

@rpokorny Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38337 diff
Batch compilation
Type count 53266 53458 +0.4%
Assignability cache size 23771 23814 +0.2%
Subtype cache size 3886 3900 +0.4%
Identity cache size 764 770 +0.8%
Language service
Samples taken 8788 2123 -75.8%
Identifiers in tests 2524 2546 +0.9%
getCompletionsAtPosition
    Mean duration (ms) 401.8 396.8 -1.3%
    Median duration (ms) 383.4 387.0 +0.9%
    Mean CV 10.3%
    Worst duration (ms) 853.0 864.3 +1.3%
    Worst identifier TransitionGroup TransitionGroup
getQuickInfoAtPosition
    Mean duration (ms) 414.2 406.1 -2.0%
    Median duration (ms) 401.5 397.8 -0.9%
    Mean CV 11.2%
    Worst duration (ms) 836.9 788.9 -5.7%
    Worst identifier component component
System information
Node version v10.15.3 v10.16.3
CPU count 2 2
CPU speed 2.294 GHz 2.394 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1041-azure 4.15.0-1055-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Sep 13, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Sep 13, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mrcrane
Copy link
Contributor

mrcrane commented Sep 24, 2019

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@mrcrane mrcrane merged commit bdfdaf7 into DefinitelyTyped:master Sep 24, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Sep 24, 2019
@typescript-bot
Copy link
Contributor

I just published @types/react@16.9.3 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants