Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@storybook/addon-a11y] remove typings provided by package directly #37358

Merged
merged 1 commit into from
Aug 5, 2019
Merged

[@storybook/addon-a11y] remove typings provided by package directly #37358

merged 1 commit into from
Aug 5, 2019

Conversation

gaetanmaisse
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

--

@storybook/addon-a11y was migrated to TS in this PR storybookjs/storybook#5738 and it was released publically in 5.1.0 (and first published on npm registry in 5.1.1)

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 4, 2019

@gaetanmaisse Thank you for submitting this PR!

🔔 @HyunSeob - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@sandersn sandersn merged commit d27c04c into DefinitelyTyped:master Aug 5, 2019
Pull Request Status Board automation moved this from Review to Done Aug 5, 2019
@gaetanmaisse gaetanmaisse deleted the delete-storybook-a11y-addon-types branch August 5, 2019 19:36
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants