-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@storybook/addon-a11y] remove typings provided by package directly #36407
[@storybook/addon-a11y] remove typings provided by package directly #36407
Conversation
@gaetanmaisse Thank you for submitting this PR! 🔔 @HyunSeob - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot is confused; the CI failures need to be addressed
CI error had nothing to see with my modification 🤷♂:
@RyanCavanaugh Anyway, I rebased on master and everything is ok now. 🚀 |
@gaetanmaisse One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
🔔 @RyanCavanaugh - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
@RyanCavanaugh any news about this PR? |
Please fill in this template.
npm test
.)Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json
.--
@storybook/addon-a11y
was migrated to TS in this PR storybookjs/storybook#5738 and it was released publically in 5.1.0 (and first published on npm registry in 5.1.1)