Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@storybook/addon-a11y] remove typings provided by package directly #36407

Closed
wants to merge 1 commit into from
Closed

[@storybook/addon-a11y] remove typings provided by package directly #36407

wants to merge 1 commit into from

Conversation

gaetanmaisse
Copy link
Contributor

@gaetanmaisse gaetanmaisse commented Jun 24, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

--

@storybook/addon-a11y was migrated to TS in this PR storybookjs/storybook#5738 and it was released publically in 5.1.0 (and first published on npm registry in 5.1.1)

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 24, 2019

@gaetanmaisse Thank you for submitting this PR!

🔔 @HyunSeob - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Jun 29, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jun 29, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot is confused; the CI failures need to be addressed

@gaetanmaisse
Copy link
Contributor Author

gaetanmaisse commented Jul 2, 2019

CI error had nothing to see with my modification 🤷‍♂:

Error: Please delete all files in webpack-dev-middleware when adding it to notNeededPackages.json.
    at util_1.mapIter.p (/home/vsts/work/1/s/node_modules/types-publisher/src/tester/test-runner.ts:110:19)
    at Object.mapIter (/home/vsts/work/1/s/node_modules/types-publisher/src/util/util.ts:237:15)
    at mapIter.next (<anonymous>)
    at Object.runTests [as default] (/home/vsts/work/1/s/node_modules/types-publisher/src/tester/test-runner.ts:75:20)

@RyanCavanaugh Anyway, I rebased on master and everything is ok now. 🚀

@typescript-bot typescript-bot moved this from Review to Needs Author Attention in Pull Request Status Board Jul 2, 2019
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Jul 2, 2019
@typescript-bot
Copy link
Contributor

@gaetanmaisse One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

🔔 @RyanCavanaugh - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@gaetanmaisse
Copy link
Contributor Author

@RyanCavanaugh any news about this PR?

Pull Request Status Board automation moved this from Needs Author Attention to Done Aug 4, 2019
@gaetanmaisse gaetanmaisse deleted the delete-storybook-a11y-addon-types branch August 5, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants