Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding [Symbol.toStringTag] to Bluebird #35353

Closed
wants to merge 2 commits into from
Closed

Adding [Symbol.toStringTag] to Bluebird #35353

wants to merge 2 commits into from

Conversation

dancrumb
Copy link
Contributor

This is a rehash of #10831, which was closed because Bluebird did not have this Symbol available back then.

Please fill in this template.

If changing an existing definition:

This is a rehash of #10831, which was closed because Bluebird did not have this Symbol available back then.
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board May 10, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels May 10, 2019
@typescript-bot
Copy link
Contributor

@dancrumb Thank you for submitting this PR!

🔔 @lhecker - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@lhecker
Copy link
Contributor

lhecker commented May 10, 2019

Unfortunately this PR is a bit incomplete and has a number of issues (I'm sorry):

  • Test cases for this new functionality are missing
  • The Symbol.toStringTag field on Bluebird promises actually returns "Object" instead of "Promise"
  • The actual signature of the property is readonly - see here
  • This in turn requires a TypeScript version upgrade of Bluebird's typings and all of its transitive dependents
  • Bluebird wasn't actually released yet with this feature unfortunately - see here

I humbly suggest to close this PR in favor of #34805.

@dancrumb
Copy link
Contributor Author

Gladly!

@dancrumb dancrumb closed this May 10, 2019
Pull Request Status Board automation moved this from Waiting for Reviewers to Done May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants