New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'del' package #33629
Remove 'del' package #33629
Conversation
@j-oliveras Thank you for submitting this PR! 🔔 @AyaMorisawa @BendingBender @bitjson @GiedriusGrabauskas @vladshcherbin @tkqubo - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
@j-oliveras The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Only coping from opening post: needs microsoft/types-publisher#586 to pass tests. |
Now, tests for
On export interface RollupOutput {
output: [OutputChunk, ...(OutputChunk | OutputAsset)[]];
} @sandersn what to do in this cases? |
rollup-plugin-delete's error actually comes from rollup, which was already required. I'm not sure why it's failing now -- perhaps it was cached on the build server until now? In any case, rollup.d.ts used to have Typescript 2.3-compatible types before 1.2.0, but upgraded them at rollup/rollup#2679, which released on February 17. So you have two choices:
I recommend (2) since 3.2 is a pretty new version of Typescript still. |
The reason rollup didn't fail until now is that the only time that we try to compile a package with all versions of typescript is when the package is actually changed. When it's just a dependent, it's only tested with |
Done: changed |
I just published |
Starting on v4.0.0 it includes types declarations: https://github.com/sindresorhus/del/releases/tag/v4.0.0
Needs microsoft/types-publisher#586 to pass tests.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with
npm test
.)Follow the advice from the readme.
Avoid common mistakes.
Run
npm run lint package-name
(ortsc
if notslint.json
is present).If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to
notNeededPackages.json
.