Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-is: Add 16.7 features #31968

Merged
merged 5 commits into from Jan 15, 2019

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 8, 2019

Changes

  • added react-is@16.7 features except anything related to ConcurrentMode since it is not implemented in @types/react yet.
  • fixed test assertions concerning forwardRef

Please fill in this template

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:
If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 8, 2019

@eps1lon Thank you for submitting this PR!

🔔 @AviVahl @christianchown - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@AviVahl AviVahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jan 8, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jan 8, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jan 9, 2019
@eps1lon
Copy link
Collaborator Author

eps1lon commented Jan 10, 2019

@AviVahl @christianchown Thanks for the quick review but I had to change the return type of the isMemo and isLazy typeguards. As the test file confirms they currently do not narrow to ReactElement but ReactComponentType.

See facebook/react#14546 for implementation details

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). and removed Popular package This PR affects a popular package (as counted by NPM download counts). labels Jan 14, 2019
@DanielRosenwasser DanielRosenwasser merged commit fc19d9d into DefinitelyTyped:master Jan 15, 2019
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jan 16, 2019
@eps1lon eps1lon deleted the feat/react-is/16-7 branch January 16, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants