(angular.js) Introduce type aliases LinkFnControllerType and RequireT…

[rkirov]

…ype.

This allows users to write callbacks using those aliases instead of the
full type.

Having convinient aliases is required for having AngularJS in TS work
better with strictFunctionTypes flag on.
see: angular/angular.js#16617

Also having them next to each other shows the symmetry between the
require and controller param better.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: AngularJs TypeScript typings and --strictFunctionTypes angular/angular.js#16617
• Increase the version number in the header if appropriate.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

[rkirov]

Hmm, the CI timedout, not sure if it is related to my change.

[typescript-bot]

@rkirov Thank you for submitting this PR!

🔔 @diegovilar @thorn0 @calebstdenis @leonard-thieu - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

@rkirov The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[thorn0]

link: (..., controller: angular.LinkFnControllerType) => {
  let myController = controller as MyControllerType;
}

You don't have to type-annotate the callback parameters here because the types are inferred. Superfluous type annotations are often seen as bad style. They definitely should be avoided in places like code examples and documentation.

[rkirov]

You are totally right, forgot about inferences of a second. Indeed, this change is not required for the strict fn types rollout, so I am closing it.