Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async.js] Added tryEach #25912

Closed
wants to merge 1 commit into from
Closed

[async.js] Added tryEach #25912

wants to merge 1 commit into from

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented May 21, 2018

There is still plenty to do to make this compatible with the latest version, but this feature was added a few versions ago:
https://caolan.github.io/async/tryEach.js.html
caolan/async#1365
https://github.com/caolan/async/blob/master/CHANGELOG.md#v240

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@SamuelMarks SamuelMarks changed the title Added tryEach [async.js] Added tryEach May 21, 2018
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board May 21, 2018
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label May 21, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented May 21, 2018

@SamuelMarks Thank you for submitting this PR!

🔔 @borisyankov @Kern0 @Penryn @fenying @pascalmartin - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@fenying
Copy link
Contributor

fenying commented May 22, 2018

Are you sure that the tryEach has a same signature of each?

Copy link
Contributor

@fenying fenying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong signature of tryEach

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board May 22, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels May 22, 2018
@typescript-bot
Copy link
Contributor

@SamuelMarks One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 22, 2018
@SamuelMarks
Copy link
Contributor Author

SamuelMarks commented May 22, 2018

@fenying Whoops, my bad, fixed.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 22, 2018
@typescript-bot
Copy link
Contributor

🔔 @fenying - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 22, 2018
Copy link
Contributor

@fenying fenying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think it's okay now.

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board May 22, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels May 22, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are anticipating a strong connection between these, can you add a quick test in case someone changes the type of parallel?

@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board May 24, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Merge:Express labels May 24, 2018
@typescript-bot
Copy link
Contributor

@SamuelMarks I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. Abandoned This PR had no activity for a long time, and is considered abandoned labels May 30, 2018
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 31, 2018
@typescript-bot
Copy link
Contributor

@SamuelMarks To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@typescript-bot typescript-bot removed this from Needs Author Attention in Pull Request Status Board May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants