Update amqplib definitions to v0.5.0 #12427
Conversation
|
Travis fails with an error unrelated to this PR: For file:/home/travis/build/DefinitelyTyped/DefinitelyTyped/chocolatechipjs/tsconfig.json
\home\travis\build\DefinitelyTyped\DefinitelyTyped\chocolatechipjs\index.d.ts
Line 1363: All declarations of 'responseURL' must have identical modifiers. |
|
It is out problem. types-2.0/HEAD is back to green. |
| import * as Promise from 'bluebird'; | ||
| import * as events from 'events'; | ||
| import shared = require('amqplib/properties'); | ||
| import callback_api = require('amqplib/callback_api'); |
There was a problem hiding this comment.
Think this callback_api import is unused?
There was a problem hiding this comment.
Completely right. Removed.
| import shared = require('amqplib/properties'); | ||
| import callback_api = require('amqplib/callback_api'); | ||
|
|
||
| export import Replies = shared.Replies; |
There was a problem hiding this comment.
A simplier syntax might be to do
export {
Replies,
Options,
Message
} from 'amqplib/properties';
There was a problem hiding this comment.
Those are inlined export imports. Your suggestion wouldn't do the same thing, am I right?
There was a problem hiding this comment.
My mistake, I thought that exporting in the fashion I suggested also imported them into the local scope
|
Assuming passes CI after rebase / merge with upstream then 👍 |
|
@mnahkies Ok, it may be a little too late now - but I just realized that for some awkward reason, When updating to [ts] Argument of type 'Bluebird<void>' is not assignable to parameter of type 'Promise<void>'.Thoughts? |
Please fill in this template.
types-2.0branch.If adding a new definition:
tscwithout errors.If changing an existing definition: