Skip to content

Commit

Permalink
🤖 Merge PR #56264 [react-tracking] Add explicit children to Trackin…
Browse files Browse the repository at this point in the history
…gComponent by @eps1lon

* [react-tracking] Add explicit `children` to TrackingComponent

* Apply suggestions from code review

Co-authored-by: Chen Asraf <chenasraf@users.noreply.github.com>

* fix failing test

Co-authored-by: Chen Asraf <chenasraf@users.noreply.github.com>
  • Loading branch information
eps1lon and chenasraf committed Oct 14, 2021
1 parent 9604c96 commit 43f742c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion types/react-tracking/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export interface Track<T = any, P = any, S = any> {
/**
* This component will pass any tracking data as context to tracking calls made in any components within its subtree.
*/
export type TrackingComponent<P = {}> = React.FC;
export type TrackingComponent<P = {}> = React.FC<React.PropsWithChildren<{}>>;

export const track: Track;
export default track;

0 comments on commit 43f742c

Please sign in to comment.