Revert "fix: function-paren-newline crash on "new new Foo();" (eslint…

…#15850)" This reverts commit b8b86c2.
DeepSourceCorp · May 30, 2022 · 6f00557 · 6f00557
1 parent f8a0935
commit 6f00557
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/lib/rules/function-paren-newline.js b/lib/rules/function-paren-newline.js
@@ -191,13 +191,10 @@ module.exports = {
         function getParenTokens(node) {
             switch (node.type) {
                 case "NewExpression":
-                    if (!node.arguments.length &&
-                        !(
-                            astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) &&
-                            astUtils.isClosingParenToken(sourceCode.getLastToken(node)) &&
-                            node.callee.range[1] < node.range[1]
-                        )
-                    ) {
+                    if (!node.arguments.length && !(
+                        astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) &&
+                        astUtils.isClosingParenToken(sourceCode.getLastToken(node))
+                    )) {
 
                         // If the NewExpression does not have parens (e.g. `new Foo`), return null.
                         return null;

diff --git a/tests/lib/rules/function-paren-newline.js b/tests/lib/rules/function-paren-newline.js
@@ -30,7 +30,6 @@ const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
 ruleTester.run("function-paren-newline", rule, {
 
     valid: [
-        "new new Foo();",
 
         // multiline option (default)
         "function baz(foo, bar) {}",
@@ -1175,18 +1174,6 @@ ruleTester.run("function-paren-newline", rule, {
             options: ["never"],
             errors: [LEFT_UNEXPECTED_ERROR]
         },
-        {
-            code: `
-                new new C()(
-                );
-            `,
-            output: `
-                new new C()();
-            `,
-            options: ["never"],
-            errors: [LEFT_UNEXPECTED_ERROR, RIGHT_UNEXPECTED_ERROR]
-        },
-
         {
             code: `
                 function baz(