Multiple target languages #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanEbbing
reviewed
May 3, 2024
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
Updating changes from feedback given
…-node into multiple_target_languages
JanEbbing
previously requested changes
May 15, 2024
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
|
Looks good from my side. Only thing left is to squash all the commits into one, and adhere to our conventional commit naming scheme. Probably makes sense to add this to the |
examples/multiple-target-languages/MultipleLanguagesIterator.js
Outdated
Show resolved
Hide resolved
daniel-jones-dev
force-pushed
the
multiple_target_languages
branch
from
646549b
to
47138a9
Compare
daniel-jones-dev
force-pushed
the
multiple_target_languages
branch
from
47138a9
to
9c12bd8
Compare
daniel-jones-dev
previously approved these changes
May 17, 2024
daniel-jones-dev
approved these changes
May 22, 2024
daniel-jones-dev
dismissed
JanEbbing’s stale review
Changes approved here #45 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing users how to translate a website into multiple languages in one go.