Add support for Jekyll 4.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekyll/jekyll#7591 was failing builds that use Jekyll 4.0, as Github Actions use a lot of the same infrastructure as Azure Pipelines (so much so that they even share bugs!)
David-Byrne
added a commit
that referenced
this pull request
Mar 8, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
David-Byrne
added a commit
that referenced
this pull request
Mar 8, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
David-Byrne
added a commit
that referenced
this pull request
Mar 8, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
David-Byrne
added a commit
that referenced
this pull request
Mar 8, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
David-Byrne
added a commit
that referenced
this pull request
Mar 9, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
David-Byrne
added a commit
that referenced
this pull request
Mar 9, 2020
There's been a few issues with Jekyll-Diff-Action using the default `/github/workspace` directory to run in. That's mounted in read only mode, so any command that tried modify it failed (see PR #1 and issue #2). To get away from all this, this PR adds an initial step to the diff script to create our own workspace with the appropriate permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jekyll/jekyll#7591 was failing builds that use Jekyll 4.0, as Github Actions use a lot of the same infrastructure as Azure Pipelines (so much so that they even share bugs!)